From mboxrd@z Thu Jan 1 00:00:00 1970 From: Takashi Iwai Date: Tue, 15 Mar 2016 09:01:35 +0000 Subject: Re: [patch] ALSA: mixart: silence unitialized variable warnings Message-Id: List-Id: References: <20160315070917.GE13560@mwanda> In-Reply-To: <20160315070917.GE13560@mwanda> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Dan Carpenter Cc: Jaroslav Kysela , alsa-devel@alsa-project.org, kernel-janitors@vger.kernel.org On Tue, 15 Mar 2016 08:09:17 +0100, Dan Carpenter wrote: > > We print can print the uninitialized memory on error. Which is an info > leak, I suppose but it's basically harmless. > > Signed-off-by: Dan Carpenter Applied, thanks. Takashi > > diff --git a/sound/pci/mixart/mixart_mixer.c b/sound/pci/mixart/mixart_mixer.c > index 24a1955..58fd79eb 100644 > --- a/sound/pci/mixart/mixart_mixer.c > +++ b/sound/pci/mixart/mixart_mixer.c > @@ -726,7 +726,7 @@ int mixart_update_playback_stream_level(struct snd_mixart* chip, int is_aes, int > int volume[2]; > struct mixart_msg request; > struct mixart_set_out_stream_level_req set_level; > - u32 status; > + u32 status = 0; > struct mixart_pipe *pipe; > > memset(&set_level, 0, sizeof(set_level)); > @@ -778,7 +778,7 @@ int mixart_update_capture_stream_level(struct snd_mixart* chip, int is_aes) > struct mixart_pipe *pipe; > struct mixart_msg request; > struct mixart_set_in_audio_level_req set_level; > - u32 status; > + u32 status = 0; > > if(is_aes) { > idx = 1; >