public inbox for kernel-janitors@vger.kernel.org
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Jaroslav Kysela <perex@perex.cz>,
	alsa-devel@alsa-project.org, kernel-janitors@vger.kernel.org,
	Arnd Bergmann <arnd@arndb.de>
Subject: Re: [alsa-devel] [patch] sound: oss/dmabuf: remove an unneeded	temporary variable
Date: Fri, 09 Aug 2013 10:38:58 +0000	[thread overview]
Message-ID: <s5hiozf2lod.wl%tiwai@suse.de> (raw)
In-Reply-To: <20130809095705.GE29282@elgon.mountain>

At Fri, 9 Aug 2013 12:57:06 +0300,
Dan Carpenter wrote:
> 
> We don't actually use the "go" variable so it can be removed.
> 
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

Thanks, applied.


Takashi

> 
> diff --git a/sound/oss/dmabuf.c b/sound/oss/dmabuf.c
> index a59c888..461d94c 100644
> --- a/sound/oss/dmabuf.c
> +++ b/sound/oss/dmabuf.c
> @@ -557,7 +557,6 @@ int DMAbuf_getrdbuffer(int dev, char **buf, int *len, int dontblock)
>  	unsigned long flags;
>  	int err = 0, n = 0;
>  	struct dma_buffparms *dmap = adev->dmap_in;
> -	int go;
>  
>  	if (!(adev->open_mode & OPEN_READ))
>  		return -EIO;
> @@ -584,7 +583,7 @@ int DMAbuf_getrdbuffer(int dev, char **buf, int *len, int dontblock)
>  			spin_unlock_irqrestore(&dmap->lock,flags);
>  			return -EAGAIN;
>  		}
> -		if ((go = adev->go))
> +		if (adev->go)
>  			timeout = dmabuf_timeout(dmap);
>  
>  		spin_unlock_irqrestore(&dmap->lock,flags);
> _______________________________________________
> Alsa-devel mailing list
> Alsa-devel@alsa-project.org
> http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
> 

  reply	other threads:[~2013-08-09 10:38 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-08-09  9:57 [patch] sound: oss/dmabuf: remove an unneeded temporary variable Dan Carpenter
2013-08-09 10:38 ` Takashi Iwai [this message]
2013-08-09 13:54 ` Takashi Iwai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=s5hiozf2lod.wl%tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=alsa-devel@alsa-project.org \
    --cc=arnd@arndb.de \
    --cc=dan.carpenter@oracle.com \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=perex@perex.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox