From: Takashi Iwai <tiwai@suse.de>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Clemens Ladisch <clemens@ladisch.de>,
Takashi Sakamoto <o-takashi@sakamocchi.jp>,
alsa-devel@alsa-project.org, Jaroslav Kysela <perex@perex.cz>,
kernel-janitors@vger.kernel.org
Subject: Re: [patch 1/2] ALSA: firewire-tascam: fix an LED bug
Date: Sat, 17 Oct 2015 10:12:08 +0000 [thread overview]
Message-ID: <s5hk2qldcsn.wl-tiwai@suse.de> (raw)
In-Reply-To: <20151015181630.GA3163@mwanda>
On Thu, 15 Oct 2015 20:16:30 +0200,
Dan Carpenter wrote:
>
> We recently tried to add some new code to support turning the LED on and
> off but the code in snd_tscm_transaction_reregister() is unreachable.
>
> Fixes: e65e2cb99e44 ('ALSA: firewire-tascam: Turn on/off FireWire LED')
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Applied, thanks.
Takashi
>
> diff --git a/sound/firewire/tascam/tascam-transaction.c b/sound/firewire/tascam/tascam-transaction.c
> index 1c9a88b..45c3ce3 100644
> --- a/sound/firewire/tascam/tascam-transaction.c
> +++ b/sound/firewire/tascam/tascam-transaction.c
> @@ -249,7 +249,7 @@ int snd_tscm_transaction_reregister(struct snd_tscm *tscm)
>
> /* Turn on messaging. */
> reg = cpu_to_be32(0x00000001);
> - return snd_fw_transaction(tscm->unit, TCODE_WRITE_QUADLET_REQUEST,
> + err = snd_fw_transaction(tscm->unit, TCODE_WRITE_QUADLET_REQUEST,
> TSCM_ADDR_BASE + TSCM_OFFSET_MIDI_TX_ON,
> ®, sizeof(reg), 0);
> if (err < 0)
>
prev parent reply other threads:[~2015-10-17 10:12 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-15 18:16 [patch 1/2] ALSA: firewire-tascam: fix an LED bug Dan Carpenter
2015-10-17 10:12 ` Takashi Iwai [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5hk2qldcsn.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=alsa-devel@alsa-project.org \
--cc=clemens@ladisch.de \
--cc=dan.carpenter@oracle.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=o-takashi@sakamocchi.jp \
--cc=perex@perex.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox