From: Takashi Iwai <tiwai@suse.de>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Jaroslav Kysela <perex@perex.cz>,
alsa-devel@alsa-project.org,
Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>,
kernel-janitors@vger.kernel.org
Subject: Re: ALSA: core: check for underflow in snd_pcm_sw_params()
Date: Thu, 24 Sep 2015 09:46:37 +0000 [thread overview]
Message-ID: <s5hk2rg5ev6.wl-tiwai@suse.de> (raw)
In-Reply-To: <20150923094228.GA13867@mwanda>
On Wed, 23 Sep 2015 11:42:28 +0200,
Dan Carpenter wrote:
>
> As far as I can see, having an invalid ->tstamp_mode is harmless, but
> adding a check silences a static checker warning.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Applied, thanks.
Takashi
>
> diff --git a/sound/core/pcm_native.c b/sound/core/pcm_native.c
> index 75888dd..4863af5 100644
> --- a/sound/core/pcm_native.c
> +++ b/sound/core/pcm_native.c
> @@ -650,7 +650,8 @@ static int snd_pcm_sw_params(struct snd_pcm_substream *substream,
> }
> snd_pcm_stream_unlock_irq(substream);
>
> - if (params->tstamp_mode > SNDRV_PCM_TSTAMP_LAST)
> + if (params->tstamp_mode < 0 ||
> + params->tstamp_mode > SNDRV_PCM_TSTAMP_LAST)
> return -EINVAL;
> if (params->proto >= SNDRV_PROTOCOL_VERSION(2, 0, 12) &&
> params->tstamp_type > SNDRV_PCM_TSTAMP_TYPE_LAST)
>
prev parent reply other threads:[~2015-09-24 9:46 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-23 9:42 ALSA: core: check for underflow in snd_pcm_sw_params() Dan Carpenter
2015-09-24 9:46 ` Takashi Iwai [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5hk2rg5ev6.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=alsa-devel@alsa-project.org \
--cc=dan.carpenter@oracle.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=perex@perex.cz \
--cc=pierre-louis.bossart@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox