* [PATCH 3/3] ALSA: firewire-motu: constify snd_rawmidi_ops structures
@ 2017-08-15 8:09 Julia Lawall
2017-08-15 8:50 ` Takashi Sakamoto
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Julia Lawall @ 2017-08-15 8:09 UTC (permalink / raw)
To: Clemens Ladisch
Cc: alsa-devel, kernel-janitors, linux-kernel, Takashi Iwai, bhumirks
These snd_rawmidi_ops structures are only passed as the third
argument of snd_rawmidi_set_ops. This argument is const, so the
snd_rawmidi_ops structures can be const too.
Done with the help of Coccinelle.
Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
---
sound/firewire/motu/motu-midi.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/sound/firewire/motu/motu-midi.c b/sound/firewire/motu/motu-midi.c
index e3acfcc..e55cab6 100644
--- a/sound/firewire/motu/motu-midi.c
+++ b/sound/firewire/motu/motu-midi.c
@@ -128,12 +128,12 @@ static void set_midi_substream_names(struct snd_motu *motu,
int snd_motu_create_midi_devices(struct snd_motu *motu)
{
- static struct snd_rawmidi_ops capture_ops = {
+ static const struct snd_rawmidi_ops capture_ops = {
.open = midi_capture_open,
.close = midi_capture_close,
.trigger = midi_capture_trigger,
};
- static struct snd_rawmidi_ops playback_ops = {
+ static const struct snd_rawmidi_ops playback_ops = {
.open = midi_playback_open,
.close = midi_playback_close,
.trigger = midi_playback_trigger,
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH 3/3] ALSA: firewire-motu: constify snd_rawmidi_ops structures
2017-08-15 8:09 [PATCH 3/3] ALSA: firewire-motu: constify snd_rawmidi_ops structures Julia Lawall
@ 2017-08-15 8:50 ` Takashi Sakamoto
2017-08-15 8:55 ` Takashi Iwai
2017-08-15 12:06 ` Takashi Iwai
2 siblings, 0 replies; 6+ messages in thread
From: Takashi Sakamoto @ 2017-08-15 8:50 UTC (permalink / raw)
To: Julia Lawall, Clemens Ladisch
Cc: alsa-devel, kernel-janitors, linux-kernel, Takashi Iwai, bhumirks
Hi,
On Aug 15 2017 17:09, Julia Lawall wrote:
> These snd_rawmidi_ops structures are only passed as the third
> argument of snd_rawmidi_set_ops. This argument is const, so the
> snd_rawmidi_ops structures can be const too.
>
> Done with the help of Coccinelle.
>
> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
>
> ---
> sound/firewire/motu/motu-midi.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/sound/firewire/motu/motu-midi.c b/sound/firewire/motu/motu-midi.c
> index e3acfcc..e55cab6 100644
> --- a/sound/firewire/motu/motu-midi.c
> +++ b/sound/firewire/motu/motu-midi.c
> @@ -128,12 +128,12 @@ static void set_midi_substream_names(struct snd_motu *motu,
>
> int snd_motu_create_midi_devices(struct snd_motu *motu)
> {
> - static struct snd_rawmidi_ops capture_ops = {
> + static const struct snd_rawmidi_ops capture_ops = {
> .open = midi_capture_open,
> .close = midi_capture_close,
> .trigger = midi_capture_trigger,
> };
> - static struct snd_rawmidi_ops playback_ops = {
> + static const struct snd_rawmidi_ops playback_ops = {
> .open = midi_playback_open,
> .close = midi_playback_close,
> .trigger = midi_playback_trigger,
Reviewed-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
Thanks
Takashi Sakamoto
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH 3/3] ALSA: firewire-motu: constify snd_rawmidi_ops structures
2017-08-15 8:09 [PATCH 3/3] ALSA: firewire-motu: constify snd_rawmidi_ops structures Julia Lawall
2017-08-15 8:50 ` Takashi Sakamoto
@ 2017-08-15 8:55 ` Takashi Iwai
2017-08-15 9:00 ` Julia Lawall
2017-08-15 12:06 ` Takashi Iwai
2 siblings, 1 reply; 6+ messages in thread
From: Takashi Iwai @ 2017-08-15 8:55 UTC (permalink / raw)
To: Julia Lawall
Cc: Clemens Ladisch, alsa-devel, bhumirks, Jaroslav Kysela,
kernel-janitors, linux-kernel
On Tue, 15 Aug 2017 10:09:54 +0200,
Julia Lawall wrote:
>
> These snd_rawmidi_ops structures are only passed as the third
> argument of snd_rawmidi_set_ops. This argument is const, so the
> snd_rawmidi_ops structures can be const too.
>
> Done with the help of Coccinelle.
>
> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
What are other two patches? Since I haven't received a cover letter,
no idea whether I overlooked them or not relevant with my tree...
thanks,
Takashi
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 3/3] ALSA: firewire-motu: constify snd_rawmidi_ops structures
2017-08-15 8:55 ` Takashi Iwai
@ 2017-08-15 9:00 ` Julia Lawall
2017-08-15 9:29 ` Takashi Iwai
0 siblings, 1 reply; 6+ messages in thread
From: Julia Lawall @ 2017-08-15 9:00 UTC (permalink / raw)
To: Takashi Iwai
Cc: Clemens Ladisch, alsa-devel, bhumirks, Jaroslav Kysela,
kernel-janitors, linux-kernel
On Tue, 15 Aug 2017, Takashi Iwai wrote:
> On Tue, 15 Aug 2017 10:09:54 +0200,
> Julia Lawall wrote:
> >
> > These snd_rawmidi_ops structures are only passed as the third
> > argument of snd_rawmidi_set_ops. This argument is const, so the
> > snd_rawmidi_ops structures can be const too.
> >
> > Done with the help of Coccinelle.
> >
> > Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
>
> What are other two patches? Since I haven't received a cover letter,
> no idea whether I overlooked them or not relevant with my tree...
Oops, I forgot to make a cover letter for this. The others are:
drivers/hid/hid-prodikeys.c
drivers/usb/gadget/function/f_midi.c
julia
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 3/3] ALSA: firewire-motu: constify snd_rawmidi_ops structures
2017-08-15 9:00 ` Julia Lawall
@ 2017-08-15 9:29 ` Takashi Iwai
0 siblings, 0 replies; 6+ messages in thread
From: Takashi Iwai @ 2017-08-15 9:29 UTC (permalink / raw)
To: Julia Lawall
Cc: Clemens Ladisch, alsa-devel, bhumirks, Jaroslav Kysela,
kernel-janitors, linux-kernel
On Tue, 15 Aug 2017 11:00:17 +0200,
Julia Lawall wrote:
>
>
>
> On Tue, 15 Aug 2017, Takashi Iwai wrote:
>
> > On Tue, 15 Aug 2017 10:09:54 +0200,
> > Julia Lawall wrote:
> > >
> > > These snd_rawmidi_ops structures are only passed as the third
> > > argument of snd_rawmidi_set_ops. This argument is const, so the
> > > snd_rawmidi_ops structures can be const too.
> > >
> > > Done with the help of Coccinelle.
> > >
> > > Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
> >
> > What are other two patches? Since I haven't received a cover letter,
> > no idea whether I overlooked them or not relevant with my tree...
>
> Oops, I forgot to make a cover letter for this. The others are:
>
> drivers/hid/hid-prodikeys.c
> drivers/usb/gadget/function/f_midi.c
OK, thanks!
Takashi
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 3/3] ALSA: firewire-motu: constify snd_rawmidi_ops structures
2017-08-15 8:09 [PATCH 3/3] ALSA: firewire-motu: constify snd_rawmidi_ops structures Julia Lawall
2017-08-15 8:50 ` Takashi Sakamoto
2017-08-15 8:55 ` Takashi Iwai
@ 2017-08-15 12:06 ` Takashi Iwai
2 siblings, 0 replies; 6+ messages in thread
From: Takashi Iwai @ 2017-08-15 12:06 UTC (permalink / raw)
To: Julia Lawall
Cc: Clemens Ladisch, alsa-devel, bhumirks, Jaroslav Kysela,
kernel-janitors, linux-kernel
On Tue, 15 Aug 2017 10:09:54 +0200,
Julia Lawall wrote:
>
> These snd_rawmidi_ops structures are only passed as the third
> argument of snd_rawmidi_set_ops. This argument is const, so the
> snd_rawmidi_ops structures can be const too.
>
> Done with the help of Coccinelle.
>
> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Thanks, applied now.
Takashi
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2017-08-15 12:06 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-08-15 8:09 [PATCH 3/3] ALSA: firewire-motu: constify snd_rawmidi_ops structures Julia Lawall
2017-08-15 8:50 ` Takashi Sakamoto
2017-08-15 8:55 ` Takashi Iwai
2017-08-15 9:00 ` Julia Lawall
2017-08-15 9:29 ` Takashi Iwai
2017-08-15 12:06 ` Takashi Iwai
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox