From: Takashi Iwai <tiwai@suse.de>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Clemens Ladisch <clemens@ladisch.de>,
Jaroslav Kysela <perex@perex.cz>,
Takashi Sakamoto <o-takashi@sakamocchi.jp>,
alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [patch 2/2] ALSA: fireworks: small leak on error path
Date: Thu, 29 May 2014 13:57:55 +0000 [thread overview]
Message-ID: <s5hr43cadr0.wl%tiwai@suse.de> (raw)
In-Reply-To: <20140528164246.GC1824@mwanda>
At Wed, 28 May 2014 19:42:46 +0300,
Dan Carpenter wrote:
>
> There was a typo here so we return directly instead of freeing "hwinfo".
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Applied, thanks.
Takashi
>
> diff --git a/sound/firewire/fireworks/fireworks.c b/sound/firewire/fireworks/fireworks.c
> index 8e856cc..996fdc4 100644
> --- a/sound/firewire/fireworks/fireworks.c
> +++ b/sound/firewire/fireworks/fireworks.c
> @@ -157,7 +157,7 @@ get_hardware_info(struct snd_efw *efw)
> /* Hardware metering. */
> if (hwinfo->phys_in_grp_count > HWINFO_MAX_CAPS_GROUPS ||
> hwinfo->phys_out_grp_count > HWINFO_MAX_CAPS_GROUPS) {
> - return -EIO;
> + err = -EIO;
> goto end;
> }
> efw->phys_in = hwinfo->phys_in;
>
prev parent reply other threads:[~2014-05-29 13:57 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-28 16:42 [patch 2/2] ALSA: fireworks: small leak on error path Dan Carpenter
2014-05-28 21:57 ` [alsa-devel] " Takashi Sakamoto
2014-05-29 13:57 ` Takashi Iwai [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5hr43cadr0.wl%tiwai@suse.de \
--to=tiwai@suse.de \
--cc=alsa-devel@alsa-project.org \
--cc=clemens@ladisch.de \
--cc=dan.carpenter@oracle.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=o-takashi@sakamocchi.jp \
--cc=perex@perex.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox