From mboxrd@z Thu Jan 1 00:00:00 1970 From: Takashi Iwai Date: Fri, 15 Jan 2021 15:52:15 +0000 Subject: Re: [PATCH][next] ALSA: usb-audio: remove initialization of param_period_time_if_needed Message-Id: List-Id: References: <20210115154151.75022-1-colin.king@canonical.com> In-Reply-To: <20210115154151.75022-1-colin.king@canonical.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Colin King Cc: alsa-devel@alsa-project.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org, Takashi Iwai , Alexander Tsoy On Fri, 15 Jan 2021 16:41:51 +0100, Colin King wrote: > > From: Colin Ian King > > Variable param_period_time_if_needed is being initialized with a value > that is never read, the assignment is redundant and can be removed. > > Addresses-Coverity: ("Unused value") > Signed-off-by: Colin Ian King This doesn't look applicable to the latest tree. Could you check again? thanks, Takashi > --- > sound/usb/pcm.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/sound/usb/pcm.c b/sound/usb/pcm.c > index f71965bf815f..ed654338f6b7 100644 > --- a/sound/usb/pcm.c > +++ b/sound/usb/pcm.c > @@ -934,7 +934,7 @@ static int setup_hw_info(struct snd_pcm_runtime *runtime, struct snd_usb_substre > { > const struct audioformat *fp; > unsigned int pt, ptmin; > - int param_period_time_if_needed = -1; > + int param_period_time_if_needed; > int err; > > runtime->hw.formats = subs->formats; > -- > 2.29.2 >