From: Takashi Iwai <tiwai@suse.de>
To: Quentin Lambert <lambert.quentin@gmail.com>
Cc: Johannes Berg <johannes@sipsolutions.net>,
Jaroslav Kysela <perex@perex.cz>,
linuxppc-dev@lists.ozlabs.org, alsa-devel@alsa-project.org,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] ALSA: aoa: convert bus code to use dev_groups
Date: Thu, 28 May 2015 14:09:10 +0000 [thread overview]
Message-ID: <s5hsiag7q0p.wl-tiwai@suse.de> (raw)
In-Reply-To: <55671F56.6080402@gmail.com>
At Thu, 28 May 2015 15:59:50 +0200,
Quentin Lambert wrote:
>
>
>
> On 28/05/2015 15:52, Takashi Iwai wrote:
> > At Thu, 28 May 2015 14:48:27 +0200,
> > Quentin Lambert wrote:
> >> You should use dev_groups instead of the dev_attrs field of struct
> >> bus_type. This converts the MDIO bus code to use the correct field.
> >>
> >> These modifications were made using Coccinelle.
> >>
> >> Signed-off-by: Quentin Lambert <lambert.quentin@gmail.com>
> > What's wrong with dev_attrs?
> > (Not offending, I'm just curious where the preference for dev_groups
> > is referred...)
>
> This patch is based on commit 4192c74940e23da727eb02b7b4ee779dde2f670,
> its message indicates that dev_attrs is going away.
OK, makes sense. Then please keep such information in the changelog.
BTW, the code in question isn't MDIO at all.
Also, it'd be better to move ATTRIBUTE_GROUPS(soundbus_dev) into
soundbus/sysfs.c, and make it this global instead of
soundbus_dev_attrs[].
Takashi
next prev parent reply other threads:[~2015-05-28 14:09 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-28 12:48 [PATCH] ALSA: aoa: convert bus code to use dev_groups Quentin Lambert
2015-05-28 13:52 ` Takashi Iwai
2015-05-28 13:59 ` Quentin Lambert
2015-05-28 14:09 ` Takashi Iwai [this message]
2015-05-28 14:43 ` Quentin Lambert
2015-05-28 15:01 ` Takashi Iwai
2015-05-29 15:49 ` Quentin Lambert
2015-05-29 15:53 ` Takashi Iwai
2015-05-28 13:59 ` Quentin Lambert
2015-06-11 8:03 ` [PATCH v2] " Quentin Lambert
2015-06-11 10:02 ` [alsa-devel] " Takashi Iwai
2015-06-11 12:04 ` Quentin Lambert
2015-06-11 12:25 ` Takashi Iwai
2015-06-12 7:55 ` Quentin Lambert
2015-06-11 11:55 ` walter harms
2015-06-11 12:06 ` Quentin Lambert
2015-06-12 8:38 ` [PATCH v3] " Quentin Lambert
2015-06-12 9:59 ` Andreas Schwab
2015-06-12 10:01 ` Quentin Lambert
2015-06-12 18:50 ` Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5hsiag7q0p.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=alsa-devel@alsa-project.org \
--cc=johannes@sipsolutions.net \
--cc=kernel-janitors@vger.kernel.org \
--cc=lambert.quentin@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=perex@perex.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox