From: Takashi Iwai <tiwai@suse.de>
To: Mark Brown <broonie@kernel.org>
Cc: Alexandre Belloni <alexandre.belloni@free-electrons.com>,
Julia Lawall <julia.lawall@lip6.fr>,
alsa-devel@alsa-project.org, garsilva@embeddedor.com,
arvind.yadav.cs@gmail.com, bhumirks@gmail.com,
andriy.shevchenko@linux.intel.com, nicolas.ferre@microchip.com,
perex@perex.cz, kernel-janitors@vger.kernel.org,
linux-kernel@vger.kernel.org,
Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Subject: Re: [alsa-devel] [PATCH] ALSA: ac97c: Fix an error handling path in 'atmel_ac97c_probe()'
Date: Thu, 31 Aug 2017 10:49:17 +0000 [thread overview]
Message-ID: <s5htw0ohv0y.wl-tiwai@suse.de> (raw)
In-Reply-To: <20170831103716.n5f7mpzr2gatulmw@sirena.org.uk>
On Thu, 31 Aug 2017 12:37:16 +0200,
Mark Brown wrote:
>
> On Thu, Aug 31, 2017 at 12:23:14PM +0200, Takashi Iwai wrote:
>
> > Ah, wait, now I see your point. It was introduced by the very recent
> > patch through Mark's asoc tree (since it was wrongly labeled as "ASoC"
> > while it isn't). That patch looks indeed fishy. The change in
> > atmel_ac97c_resume() is also bad.
>
> The resume check looks fine? The function appears to do nothing other
> than the clk_prepare_enable().
Well, the patch behaves correctly but the code is ugly:
int ret = clk_prepare_enable(chip->pclk);
return ret;
> > So, I'd prefer reverting the wrong commit instead, and leave some
> > comment about the uselessness of clk_prepare_enable() return value
> > check.
>
> I'd rather keep the error checking there, it means that people don't
> need to open the code and verify it when they go scanning for potential
> problems.
OK.
Takashi
next prev parent reply other threads:[~2017-08-31 10:49 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-31 4:40 [PATCH] ALSA: ac97c: Fix an error handling path in 'atmel_ac97c_probe()' Christophe JAILLET
2017-08-31 8:10 ` [alsa-devel] " Alexandre Belloni
2017-08-31 8:23 ` Julia Lawall
2017-08-31 9:04 ` Andy Shevchenko
2017-08-31 9:35 ` Alexandre Belloni
2017-08-31 9:38 ` Andy Shevchenko
2017-08-31 9:57 ` Alexandre Belloni
2017-08-31 9:56 ` Alexandre Belloni
2017-08-31 10:13 ` Takashi Iwai
2017-08-31 10:19 ` Alexandre Belloni
2017-08-31 10:23 ` Takashi Iwai
2017-08-31 10:37 ` Mark Brown
2017-08-31 10:49 ` Takashi Iwai [this message]
2017-08-31 10:19 ` Mark Brown
2017-08-31 10:31 ` Takashi Iwai
2017-08-31 10:38 ` Mark Brown
2017-08-31 19:08 ` Christophe JAILLET
2017-08-31 20:50 ` Alexandre Belloni
2017-08-31 21:07 ` Julia Lawall
2017-08-31 11:55 ` Applied "ALSA: ac97c: Fix an error handling path in 'atmel_ac97c_probe()'" to the asoc tree Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5htw0ohv0y.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=alexandre.belloni@free-electrons.com \
--cc=alsa-devel@alsa-project.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=arvind.yadav.cs@gmail.com \
--cc=bhumirks@gmail.com \
--cc=broonie@kernel.org \
--cc=christophe.jaillet@wanadoo.fr \
--cc=garsilva@embeddedor.com \
--cc=julia.lawall@lip6.fr \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nicolas.ferre@microchip.com \
--cc=perex@perex.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox