From: Takashi Iwai <tiwai@suse.de>
To: David Henningsson <david.henningsson@canonical.com>
Cc: alsa-devel@alsa-project.org, kernel-janitors@vger.kernel.org,
Dan Carpenter <dan.carpenter@oracle.com>
Subject: Re: [alsa-devel] [patch] ALSA: hda/realtek - cleanup a condition
Date: Mon, 06 Feb 2012 09:09:51 +0000 [thread overview]
Message-ID: <s5hty34qqe8.wl%tiwai@suse.de> (raw)
In-Reply-To: <4F2F89F3.4060301@canonical.com>
At Mon, 06 Feb 2012 09:06:11 +0100,
David Henningsson wrote:
>
> On 02/06/2012 08:52 AM, Dan Carpenter wrote:
> > Sparse complains that "spec->multiout.dac_nids" is a pointer.
> >
> > sound/pci/hda/patch_realtek.c:2321:37: error: incompatible types for operation (>)
> > sound/pci/hda/patch_realtek.c:2321:37: left side has type unsigned short const [usertype] *dac_nids
> > sound/pci/hda/patch_realtek.c:2321:37: right side has type int
> >
> > I think the intent here was just to check if it was non-NULL, but please
> > double check.
>
> It could also have meant to be "if (spec->multiout.num_dacs > 0)", but
> either way, it seems very unlikely that the condition is false.
Yeah, I think so. Looks like David can read my old mind better than
me through his crystal ball.
I'll fix it up. Thanks.
Takashi
prev parent reply other threads:[~2012-02-06 9:09 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-06 7:52 [patch] ALSA: hda/realtek - cleanup a condition Dan Carpenter
2012-02-06 8:06 ` [alsa-devel] " David Henningsson
2012-02-06 9:09 ` Takashi Iwai [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5hty34qqe8.wl%tiwai@suse.de \
--to=tiwai@suse.de \
--cc=alsa-devel@alsa-project.org \
--cc=dan.carpenter@oracle.com \
--cc=david.henningsson@canonical.com \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox