From: Takashi Iwai <tiwai@suse.de>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Jaroslav Kysela <perex@perex.cz>,
alsa-devel@alsa-project.org, kernel-janitors@vger.kernel.org
Subject: Re: [patch] sound/sb_ess: white space cleanups
Date: Wed, 25 Feb 2015 19:09:43 +0000 [thread overview]
Message-ID: <s5hwq353j0o.wl-tiwai@suse.de> (raw)
In-Reply-To: <20150225133143.GP19745@mwanda>
At Wed, 25 Feb 2015 16:31:43 +0300,
Dan Carpenter wrote:
>
> These weren't aligned on the same lines as the surrounding code and the
> printk was quite messy.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Applied, thanks.
Takashi
>
> diff --git a/sound/oss/sb_ess.c b/sound/oss/sb_ess.c
> index b47a690..57f7d25 100644
> --- a/sound/oss/sb_ess.c
> +++ b/sound/oss/sb_ess.c
> @@ -604,7 +604,7 @@ static void ess_audio_output_block_audio2
> ess_chgmixer (devc, 0x78, 0x03, 0x03); /* Go */
>
> devc->irq_mode_16 = IMODE_OUTPUT;
> - devc->intr_active_16 = 1;
> + devc->intr_active_16 = 1;
> }
>
> static void ess_audio_output_block
> @@ -1183,17 +1183,12 @@ FKS_test (devc);
> chip = "ES1688";
> }
>
> - printk ( KERN_INFO "ESS chip %s %s%s\n"
> - , chip
> - , ( devc->sbmo.esstype = ESSTYPE_DETECT || devc->sbmo.esstype = ESSTYPE_LIKE20
> - ? "detected"
> - : "specified"
> - )
> - , ( devc->sbmo.esstype = ESSTYPE_LIKE20
> - ? " (kernel 2.0 compatible)"
> - : ""
> - )
> - );
> + printk(KERN_INFO "ESS chip %s %s%s\n", chip,
> + (devc->sbmo.esstype = ESSTYPE_DETECT ||
> + devc->sbmo.esstype = ESSTYPE_LIKE20) ?
> + "detected" : "specified",
> + devc->sbmo.esstype = ESSTYPE_LIKE20 ?
> + " (kernel 2.0 compatible)" : "");
>
> sprintf(name,"ESS %s AudioDrive (rev %d)", chip, ess_minor & 0x0f);
> } else {
>
prev parent reply other threads:[~2015-02-25 19:09 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-25 13:31 [patch] sound/sb_ess: white space cleanups Dan Carpenter
2015-02-25 19:09 ` Takashi Iwai [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5hwq353j0o.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=alsa-devel@alsa-project.org \
--cc=dan.carpenter@oracle.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=perex@perex.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox