From: Takashi Iwai <tiwai@suse.de>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: alsa-devel@alsa-project.org, kernel-janitors@vger.kernel.org,
Amitoj Kaur Chawla <amitoj1606@gmail.com>
Subject: Re: [patch] sound: oss/ad1848: remove some dead code
Date: Tue, 31 Jan 2017 20:41:42 +0000 [thread overview]
Message-ID: <s5hzii7j721.wl-tiwai@suse.de> (raw)
In-Reply-To: <20170131113331.GA3434@mwanda>
On Tue, 31 Jan 2017 12:33:31 +0100,
Dan Carpenter wrote:
>
> We never use the irq2dev[] array so we can remove this assignment.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Thanks, applied now.
Takashi
>
> diff --git a/sound/oss/ad1848.c b/sound/oss/ad1848.c
> index 6368e5c7d0ba..f6156d8169d0 100644
> --- a/sound/oss/ad1848.c
> +++ b/sound/oss/ad1848.c
> @@ -121,11 +121,6 @@ static bool deskpro_xl;
> static bool deskpro_m;
> static bool soundpro;
>
> -static volatile signed char irq2dev[17] = {
> - -1, -1, -1, -1, -1, -1, -1, -1,
> - -1, -1, -1, -1, -1, -1, -1, -1, -1
> -};
> -
> #ifndef EXCLUDE_TIMERS
> static int timer_installed = -1;
> #endif
> @@ -2060,7 +2055,7 @@ int ad1848_init (char *name, struct resource *ports, int irq, int dma_playback,
> else
> devc->irq_ok = 1; /* Couldn't test. assume it's OK */
> } else if (irq < 0)
> - irq2dev[-irq] = devc->dev_no = my_dev;
> + devc->dev_no = my_dev;
>
> #ifndef EXCLUDE_TIMERS
> if ((capabilities[devc->model].flags & CAP_F_TIMER) &&
>
prev parent reply other threads:[~2017-01-31 20:41 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-31 11:33 [patch] sound: oss/ad1848: remove some dead code Dan Carpenter
2017-01-31 20:41 ` Takashi Iwai [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5hzii7j721.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=alsa-devel@alsa-project.org \
--cc=amitoj1606@gmail.com \
--cc=dan.carpenter@oracle.com \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox