From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Martin K. Petersen" Date: Wed, 07 Feb 2018 01:25:39 +0000 Subject: Re: [PATCH] scsi: qedf: remove redundant initialization of 'fcport' Message-Id: List-Id: References: <20180206140316.31453-1-colin.king@canonical.com> In-Reply-To: <20180206140316.31453-1-colin.king@canonical.com> (Colin King's message of "Tue, 6 Feb 2018 14:03:16 +0000") MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Colin King Cc: QLogic-Storage-Upstream@cavium.com, "James E . J . Bottomley" , "Martin K . Petersen" , linux-scsi@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Colin, > Pointer fcport is initialized with a value that is never read, it is > re-assigned a new value later on, hence the initialization is redundant > and can be removed. Applied to 4.17/scsi-queue. Thanks! -- Martin K. Petersen Oracle Linux Engineering