From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Martin K. Petersen" Date: Thu, 30 May 2019 01:55:42 +0000 Subject: Re: [PATCH][next] scsi: hpsa: fix an uninitialized read and dereference of pointer dev Message-Id: List-Id: References: <20190522083903.18849-1-colin.king@canonical.com> In-Reply-To: <20190522083903.18849-1-colin.king@canonical.com> (Colin King's message of "Wed, 22 May 2019 09:39:03 +0100") MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Colin King Cc: Don Brace , "James E . J . Bottomley" , "Martin K . Petersen" , esc.storagedev@microsemi.com, linux-scsi@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Colin, > Currently the check for a lockup_detected failure exits via the label > return_reset_status that reads and dereferences an uninitialized > pointer dev. Fix this by ensuring dev is inintialized to null. Applied to 5.3/scsi-queue, thanks! -- Martin K. Petersen Oracle Linux Engineering