From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Martin K. Petersen" Date: Thu, 15 Feb 2018 23:44:19 +0000 Subject: Re: [patch RESEND] atp870u: 64 bit bug in atp885_init() Message-Id: List-Id: References: <20151209102453.GE3173@mwanda> In-Reply-To: <20151209102453.GE3173@mwanda> (Dan Carpenter's message of "Wed, 14 Feb 2018 15:02:31 +0300") MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Ondrej Zary Cc: Dan Carpenter , "James E.J. Bottomley" , "Martin K. Petersen" , linux-scsi@vger.kernel.org, kernel-janitors@vger.kernel.org, Hannes Reinecke > On 64 bit CPUs there is a memory corruption bug on probe(). It should > be a u32 pointer instead of an unsigned long pointer or we write past > the end of the setupdata[] array. Ondrej, please review! -- Martin K. Petersen Oracle Linux Engineering