* [PATCH -next] scsi: libfc: remove set but not used variable 'rpriv'
@ 2018-09-04 3:31 YueHaibing
2018-09-04 7:12 ` Johannes Thumshirn
` (4 more replies)
0 siblings, 5 replies; 6+ messages in thread
From: YueHaibing @ 2018-09-04 3:31 UTC (permalink / raw)
To: kernel-janitors
Fixes gcc '-Wunused-but-set-variable' warning:
drivers/scsi/libfc/fc_fcp.c: In function 'fc_queuecommand':
drivers/scsi/libfc/fc_fcp.c:1875:30: warning:
variable 'rpriv' set but not used [-Wunused-but-set-variable]
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
drivers/scsi/libfc/fc_fcp.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/scsi/libfc/fc_fcp.c b/drivers/scsi/libfc/fc_fcp.c
index 563247d..b1bd283 100644
--- a/drivers/scsi/libfc/fc_fcp.c
+++ b/drivers/scsi/libfc/fc_fcp.c
@@ -1872,7 +1872,6 @@ int fc_queuecommand(struct Scsi_Host *shost, struct scsi_cmnd *sc_cmd)
struct fc_lport *lport = shost_priv(shost);
struct fc_rport *rport = starget_to_rport(scsi_target(sc_cmd->device));
struct fc_fcp_pkt *fsp;
- struct fc_rport_libfc_priv *rpriv;
int rval;
int rc = 0;
struct fc_stats *stats;
@@ -1894,8 +1893,6 @@ int fc_queuecommand(struct Scsi_Host *shost, struct scsi_cmnd *sc_cmd)
goto out;
}
- rpriv = rport->dd_data;
-
if (!fc_fcp_lport_queue_ready(lport)) {
if (lport->qfull) {
if (fc_fcp_can_queue_ramp_down(lport))
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH -next] scsi: libfc: remove set but not used variable 'rpriv'
2018-09-04 3:31 [PATCH -next] scsi: libfc: remove set but not used variable 'rpriv' YueHaibing
@ 2018-09-04 7:12 ` Johannes Thumshirn
2018-09-12 1:00 ` Martin K. Petersen
` (3 subsequent siblings)
4 siblings, 0 replies; 6+ messages in thread
From: Johannes Thumshirn @ 2018-09-04 7:12 UTC (permalink / raw)
To: kernel-janitors
Acked-by: Johannes Thumshirn <jth@kernel.org>
--
Johannes Thumshirn Storage
jthumshirn@suse.de +49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)
Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH -next] scsi: libfc: remove set but not used variable 'rpriv'
2018-09-04 3:31 [PATCH -next] scsi: libfc: remove set but not used variable 'rpriv' YueHaibing
2018-09-04 7:12 ` Johannes Thumshirn
@ 2018-09-12 1:00 ` Martin K. Petersen
2018-11-16 10:28 ` [PATCH -next] scsi: libfc: Remove set but not used variable 'disc' Johannes Thumshirn
` (2 subsequent siblings)
4 siblings, 0 replies; 6+ messages in thread
From: Martin K. Petersen @ 2018-09-12 1:00 UTC (permalink / raw)
To: kernel-janitors
YueHaibing,
> Fixes gcc '-Wunused-but-set-variable' warning:
>
> drivers/scsi/libfc/fc_fcp.c: In function 'fc_queuecommand':
> drivers/scsi/libfc/fc_fcp.c:1875:30: warning:
> variable 'rpriv' set but not used [-Wunused-but-set-variable]
Applied to 4.20/scsi-queue. Thank you!
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH -next] scsi: libfc: Remove set but not used variable 'disc'
2018-09-04 3:31 [PATCH -next] scsi: libfc: remove set but not used variable 'rpriv' YueHaibing
2018-09-04 7:12 ` Johannes Thumshirn
2018-09-12 1:00 ` Martin K. Petersen
@ 2018-11-16 10:28 ` Johannes Thumshirn
2018-11-22 3:15 ` Martin K. Petersen
2018-11-22 3:24 ` YueHaibing
4 siblings, 0 replies; 6+ messages in thread
From: Johannes Thumshirn @ 2018-11-16 10:28 UTC (permalink / raw)
To: kernel-janitors
Looks good,
Reviewed-by: Johannes Thumshirn <jth@kernel.org>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH -next] scsi: libfc: Remove set but not used variable 'disc'
2018-09-04 3:31 [PATCH -next] scsi: libfc: remove set but not used variable 'rpriv' YueHaibing
` (2 preceding siblings ...)
2018-11-16 10:28 ` [PATCH -next] scsi: libfc: Remove set but not used variable 'disc' Johannes Thumshirn
@ 2018-11-22 3:15 ` Martin K. Petersen
2018-11-22 3:24 ` YueHaibing
4 siblings, 0 replies; 6+ messages in thread
From: Martin K. Petersen @ 2018-11-22 3:15 UTC (permalink / raw)
To: kernel-janitors
YueHaibing,
> From: Yue Haibing <yuehaibing@huawei.com>
>
> Fixes gcc '-Wunused-but-set-variable' warning:
>
> drivers/scsi/libfc/fc_rport.c: In function 'fc_rport_recv_flogi_req':
> drivers/scsi/libfc/fc_rport.c:866:18: warning:
> variable 'disc' set but not used [-Wunused-but-set-variable]
>
> It no used any more after
> commit baa6719f902a （"libfc: Update rport reference counting")
^^^
Please run checkpatch. Fixed it up and applied to 4.21/scsi-queue.
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH -next] scsi: libfc: Remove set but not used variable 'disc'
2018-09-04 3:31 [PATCH -next] scsi: libfc: remove set but not used variable 'rpriv' YueHaibing
` (3 preceding siblings ...)
2018-11-22 3:15 ` Martin K. Petersen
@ 2018-11-22 3:24 ` YueHaibing
4 siblings, 0 replies; 6+ messages in thread
From: YueHaibing @ 2018-11-22 3:24 UTC (permalink / raw)
To: kernel-janitors
On 2018/11/22 11:15, Martin K. Petersen wrote:
>
> YueHaibing,
>
>> From: Yue Haibing <yuehaibing@huawei.com>
>>
>> Fixes gcc '-Wunused-but-set-variable' warning:
>>
>> drivers/scsi/libfc/fc_rport.c: In function 'fc_rport_recv_flogi_req':
>> drivers/scsi/libfc/fc_rport.c:866:18: warning:
>> variable 'disc' set but not used [-Wunused-but-set-variable]
>>
>> It no used any more after
>> commit baa6719f902a （"libfc: Update rport reference counting")
> ^^^
>
> Please run checkpatch. Fixed it up and applied to 4.21/scsi-queue.
Sorry for this， I will remember to do it next time.
>
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2018-11-22 3:24 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-09-04 3:31 [PATCH -next] scsi: libfc: remove set but not used variable 'rpriv' YueHaibing
2018-09-04 7:12 ` Johannes Thumshirn
2018-09-12 1:00 ` Martin K. Petersen
2018-11-16 10:28 ` [PATCH -next] scsi: libfc: Remove set but not used variable 'disc' Johannes Thumshirn
2018-11-22 3:15 ` Martin K. Petersen
2018-11-22 3:24 ` YueHaibing
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).