From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Martin K. Petersen" Date: Sat, 13 Apr 2019 00:06:01 +0000 Subject: Re: [PATCH][V3] scsi: cxgbi: remove redundant __kfree_skb call on skb and free cst->atid Message-Id: List-Id: References: <20190412083301.25503-1-colin.king@canonical.com> In-Reply-To: <20190412083301.25503-1-colin.king@canonical.com> (Colin King's message of "Fri, 12 Apr 2019 09:33:01 +0100") MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Colin King Cc: Karen Xie , "James E . J . Bottomley" , "Martin K . Petersen" , linux-scsi@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Colin, > The error return path via label rel_resource checks for a non-null skb > before free'ing it. However, skb is always null at this exit path, so > the null check and the free are redundant and can be removed. > Removing this allows the original goto's to rel_resource to be cleaned > up; the first can be replaced by a return of -EINVAL, the second can > be replaced by a more appropriate -ENOMEM return and fix a memory leak > by freeing csk->atid. Applied to 5.2/scsi-queue, thanks! -- Martin K. Petersen Oracle Linux Engineering