From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Martin K. Petersen" Date: Wed, 16 Dec 2015 22:50:17 +0000 Subject: Re: [patch] qla2xxx: fix a timeout loop Message-Id: List-Id: References: <20151216110746.GB21018@mwanda> In-Reply-To: <20151216110746.GB21018@mwanda> (Dan Carpenter's message of "Wed, 16 Dec 2015 14:07:46 +0300") MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Dan Carpenter Cc: qla2xxx-upstream@qlogic.com, Atul Deshmukh , "James E.J. Bottomley" , "Martin K. Petersen" , linux-scsi@vger.kernel.org, kernel-janitors@vger.kernel.org, Johannes Thumshirn >>>>> "Dan" = Dan Carpenter writes: Dan> After the loop we test for "if (!retries) " as a failure, but Dan> actually the post-op here will end with retries set to -1. I have Dan> fixed this by using a pre-op instead. Applied to 4.4/scsi-fixes. -- Martin K. Petersen Oracle Linux Engineering