* [PATCH] scsi: aacraid: fix a signednes bug
@ 2018-08-27 9:23 Dan Carpenter
2018-08-27 17:02 ` Martin K. Petersen
0 siblings, 1 reply; 2+ messages in thread
From: Dan Carpenter @ 2018-08-27 9:23 UTC (permalink / raw)
To: kernel-janitors
The problem is that ->reset_state is a u8 but it can be set to -1 or -2
in aac_tmf_callback() and the error handling in aac_eh_target_reset()
relies on it to be signed.
Fixes: 0d643ff3c353 ("scsi: aacraid: use aac_tmf_callback for reset fib")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/scsi/aacraid/aacraid.h b/drivers/scsi/aacraid/aacraid.h
index 29bf1e60f542..39eb415987fc 100644
--- a/drivers/scsi/aacraid/aacraid.h
+++ b/drivers/scsi/aacraid/aacraid.h
@@ -1346,7 +1346,7 @@ struct fib {
struct aac_hba_map_info {
__le32 rmw_nexus; /* nexus for native HBA devices */
u8 devtype; /* device type */
- u8 reset_state; /* 0 - no reset, 1..x - */
+ s8 reset_state; /* 0 - no reset, 1..x - */
/* after xth TM LUN reset */
u16 qd_limit;
u32 scan_counter;
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] scsi: aacraid: fix a signednes bug
2018-08-27 9:23 [PATCH] scsi: aacraid: fix a signednes bug Dan Carpenter
@ 2018-08-27 17:02 ` Martin K. Petersen
0 siblings, 0 replies; 2+ messages in thread
From: Martin K. Petersen @ 2018-08-27 17:02 UTC (permalink / raw)
To: kernel-janitors
Dan,
> The problem is that ->reset_state is a u8 but it can be set to -1 or
> -2 in aac_tmf_callback() and the error handling in
> aac_eh_target_reset() relies on it to be signed.
Applied to 4.19/scsi-fixes, thank you!
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-08-27 17:02 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-08-27 9:23 [PATCH] scsi: aacraid: fix a signednes bug Dan Carpenter
2018-08-27 17:02 ` Martin K. Petersen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).