From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Johannes Thumshirn <jth@kernel.org>, Robert Love <rml@tech9.net>,
"James E.J. Bottomley" <jejb@linux.vnet.ibm.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
fcoe-devel@open-fcoe.org, linux-scsi@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] scsi: libfc: pass an error pointer to fc_disc_error()
Date: Wed, 12 Jul 2017 21:25:42 +0000 [thread overview]
Message-ID: <yq1wp7djqjt.fsf@oracle.com> (raw)
In-Reply-To: <20170712073022.e24r3iad7jqxarn6@mwanda> (Dan Carpenter's message of "Wed, 12 Jul 2017 10:30:22 +0300")
Dan,
> This patch is basically to silence a static checker warning.
>
> drivers/scsi/libfc/fc_disc.c:326 fc_disc_error()
> warn: passing a valid pointer to 'PTR_ERR'
>
> It doesn't affect runtime because it treats -ENOMEM and a valid pointer
> the same. But the documentation says we should be passing an error
> pointer.
Applied to 4.13/scsi-fixes. Thank you!
--
Martin K. Petersen Oracle Linux Engineering
prev parent reply other threads:[~2017-07-12 21:25 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-12 7:30 [PATCH] scsi: libfc: pass an error pointer to fc_disc_error() Dan Carpenter
2017-07-12 7:54 ` Johannes Thumshirn
2017-07-12 21:25 ` Martin K. Petersen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq1wp7djqjt.fsf@oracle.com \
--to=martin.petersen@oracle.com \
--cc=dan.carpenter@oracle.com \
--cc=fcoe-devel@open-fcoe.org \
--cc=jejb@linux.vnet.ibm.com \
--cc=jth@kernel.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=rml@tech9.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox