From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Adaptec OEM Raid Solutions <aacraid@adaptec.com>,
Quentin Lambert <lambert.quentin@gmail.com>,
"James E.J. Bottomley" <jejb@linux.vnet.ibm.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
linux-scsi@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [patch] scsi: dpt_i2o: double free on error path
Date: Thu, 01 Dec 2016 00:54:46 +0000 [thread overview]
Message-ID: <yq1wpfkh3jd.fsf@sermon.lab.mkp.net> (raw)
In-Reply-To: <20161130193648.GA24818@mwanda> (Dan Carpenter's message of "Wed, 30 Nov 2016 22:36:48 +0300")
>>>>> "Dan" = Dan Carpenter <dan.carpenter@oracle.com> writes:
Dan> We recently introduced a kfree() in the caller for this function.
Dan> That's where, logically, you would think the kfree() should be.
Dan> Unfortunately the code was just ugly and not buggy so the static
Dan> checker warning was a false postive and introduced a double free.
Dan> I've removed the old kfree() and left the new one.
Applied to 4.10/scsi-queue.
--
Martin K. Petersen Oracle Linux Engineering
prev parent reply other threads:[~2016-12-01 0:54 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-30 19:36 [patch] scsi: dpt_i2o: double free on error path Dan Carpenter
2016-11-30 20:18 ` Quentin Lambert
2016-12-01 0:54 ` Martin K. Petersen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq1wpfkh3jd.fsf@sermon.lab.mkp.net \
--to=martin.petersen@oracle.com \
--cc=aacraid@adaptec.com \
--cc=dan.carpenter@oracle.com \
--cc=jejb@linux.vnet.ibm.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=lambert.quentin@gmail.com \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).