From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mike Galbraith Subject: Re: [Bug #11308] tbench regression on each kernel release from 2.6.22 -> 2.6.28 Date: Wed, 17 Sep 2008 13:41:41 +0200 Message-ID: <1221651701.5102.17.camel@marge.simson.net> References: <48CAE7A0.8000004@linux-foundation.org> <1221306287.5213.111.camel@marge.simson.net> <48CD1D25.9080301@linux-foundation.org> <1221421907.4597.24.camel@marge.simson.net> <1221475440.4784.39.camel@marge.simson.net> <1221568105.5020.17.camel@marge.simson.net> <1221626391.5043.13.camel@marge.simson.net> <1221627676.5125.3.camel@marge.simson.net> <20080917104044.GC18764@elte.hu> Mime-Version: 1.0 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: In-Reply-To: <20080917104044.GC18764-X9Un+BFzKDI@public.gmane.org> Sender: kernel-testers-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-ID: Content-Type: text/plain; charset="iso-8859-1" To: Ingo Molnar Cc: Ilpo =?ISO-8859-1?Q?J=E4rvinen?= , Christoph Lameter , "Rafael J. Wysocki" , LKML , kernel-testers-u79uwXL29TY76Z2rM5mHXA@public.gmane.org On Wed, 2008-09-17 at 12:40 +0200, Ingo Molnar wrote: > * Mike Galbraith wrote: >=20 > > On Wed, 2008-09-17 at 06:40 +0200, Mike Galbraith wrote: > > > On Tue, 2008-09-16 at 17:07 +0300, Ilpo J=C3=A4rvinen wrote: > >=20 > > > > One additional sanity check could be to rebase security 6f0f0fd= 4963 on top=20 > > > > of the c142bda458a and then see if bisection among those securi= ty commits=20 > > > > on top yields to the the same result... Though I doubt it can c= hange much=20 > > > > because there was not that much relevant non-security things in= the merge=20 > > > > in question. > > >=20 > > > I'm not a master of git-foo, so that is not an option. However, = a dinky > > > bisection c142bda4..847106f very clearly says... > > >=20 > > > marge:..kernel/linux-2.6.27.git # git bisect bad > > > 6f0f0fd496333777d53daff21a4e3b28c4d03a6d is first bad commit > > > commit 6f0f0fd496333777d53daff21a4e3b28c4d03a6d > > > Author: James Morris > > > Date: Thu Jul 10 17:02:07 2008 +0900 > > >=20 > > > security: remove register_security hook > > >=20 > > > The register security hook is no longer required, as the capa= bility > > > module is always registered. LSMs wishing to stack capabilit= y as > > > a secondary module should do so explicitly. > > >=20 > > > Signed-off-by: James Morris > > > Acked-by: Stephen Smalley > > > Acked-by: Greg Kroah-Hartman > > >=20 > > > :040000 040000 0177ef46d305e51e27bfcc4350a40577f8ba8d3d 64b64c10a= 424df4539653a8ee34f1a2329300931 M include > > > :040000 040000 e318891e514de674fd064f6bfad70d5633b1aff1 0dbb38d5a= a7fc3e4b2e09dc65796ce7cd5faeb26 M security > >=20 > > Which is high grade horse-pookey. >=20 > perhaps re-test commit 6f0f0fd49 and its parent commit, 93cbace7a0. Will do. > It looks like a potentially bogus bisection result, but _maybe_ it ha= s=20 > relevance: changes the size of "struct security_operations", which co= uld=20 > have alignment and layout effects on all sorts of kernel variables,=20 > kmalloc sizes, etc. This may well be a mythical creature infestation for all I know ;-), bu= t it's address is somewhere in the 2069f45..847106f block, 316 commits, none of which look like they should be the least bit interesting to netperf. I reverted this particular commit in 27.git, got the expected result. Looks like I'll keep poking at it, can't seem to resist. Grr. -Mike