* [PATCH] ipw2200: make assocaittion only if SSID is known.
@ 2008-11-05 8:45 Alexey Fisher
[not found] ` <1225874758-5948-1-git-send-email-bug-track-M18mAb7Tlt0yCq4wW13eYl6hYfS7NtTn@public.gmane.org>
0 siblings, 1 reply; 3+ messages in thread
From: Alexey Fisher @ 2008-11-05 8:45 UTC (permalink / raw)
To: linux-wireless-u79uwXL29TY76Z2rM5mHXA
Cc: linville-2XuSBdqkA4R54TAoqtyWWQ, rjw-KKrjLPT3xs0,
kernel-testers-u79uwXL29TY76Z2rM5mHXA, Alexey Fisher
'iwconfig eth1 channel 6' would trigger association to _something_,
which is wrong. Changing the channel should (and does) trigger reassociation,
but only if there is an SSID to associate with.
Signed-off-by: Alexey Fisher <bug-track-M18mAb7Tlt0yCq4wW13eYl6hYfS7NtTn@public.gmane.org>
---
drivers/net/wireless/ipw2200.c | 3 +--
1 files changed, 1 insertions(+), 2 deletions(-)
diff --git a/drivers/net/wireless/ipw2200.c b/drivers/net/wireless/ipw2200.c
index dcce354..d26beed 100644
--- a/drivers/net/wireless/ipw2200.c
+++ b/drivers/net/wireless/ipw2200.c
@@ -7581,8 +7581,7 @@ static int ipw_associate(void *data)
}
if (!(priv->config & CFG_ASSOCIATE) &&
- !(priv->config & (CFG_STATIC_ESSID |
- CFG_STATIC_CHANNEL | CFG_STATIC_BSSID))) {
+ !(priv->config & (CFG_STATIC_ESSID | CFG_STATIC_BSSID))) {
IPW_DEBUG_ASSOC("Not attempting association (associate=0)\n");
return 0;
}
--
1.5.6.3
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] ipw2200: make assocaittion only if SSID is known.
[not found] ` <1225874758-5948-1-git-send-email-bug-track-M18mAb7Tlt0yCq4wW13eYl6hYfS7NtTn@public.gmane.org>
@ 2008-11-06 1:03 ` Zhu Yi
0 siblings, 0 replies; 3+ messages in thread
From: Zhu Yi @ 2008-11-06 1:03 UTC (permalink / raw)
To: Alexey Fisher
Cc: linux-wireless-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linville-2XuSBdqkA4R54TAoqtyWWQ@public.gmane.org,
rjw-KKrjLPT3xs0@public.gmane.org,
kernel-testers-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
On Wed, 2008-11-05 at 16:45 +0800, Alexey Fisher wrote:
> 'iwconfig eth1 channel 6' would trigger association to _something_,
> which is wrong. Changing the channel should (and does) trigger
> reassociation,
> but only if there is an SSID to associate with.
>
> Signed-off-by: Alexey Fisher <bug-track-M18mAb7Tlt0yCq4wW13eYl6hYfS7NtTn@public.gmane.org>
Acked-by: Zhu Yi <yi.zhu-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
Thanks,
-yi
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH] ipw2200: make assocaittion only if SSID is known.
@ 2008-11-06 8:51 Alexey Fisher
0 siblings, 0 replies; 3+ messages in thread
From: Alexey Fisher @ 2008-11-06 8:51 UTC (permalink / raw)
To: linux-wireless-u79uwXL29TY76Z2rM5mHXA
Cc: linville-2XuSBdqkA4R54TAoqtyWWQ, rjw-KKrjLPT3xs0,
kernel-testers-u79uwXL29TY76Z2rM5mHXA,
torvalds-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b,
yi.zhu-ral2JQCrhuEAvxtiuMwx3w, Alexey Fisher
'iwconfig eth1 channel 6' would trigger association to _something_,
which is wrong. Changing the channel should (and does) trigger reassociation,
but only if there is an SSID to associate with.
Signed-off-by: Alexey Fisher <bug-track-M18mAb7Tlt0yCq4wW13eYl6hYfS7NtTn@public.gmane.org>
Acked-by: Zhu Yi <yi.zhu-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
---
drivers/net/wireless/ipw2200.c | 3 +--
1 files changed, 1 insertions(+), 2 deletions(-)
diff --git a/drivers/net/wireless/ipw2200.c b/drivers/net/wireless/ipw2200.c
index dcce354..d26beed 100644
--- a/drivers/net/wireless/ipw2200.c
+++ b/drivers/net/wireless/ipw2200.c
@@ -7581,8 +7581,7 @@ static int ipw_associate(void *data)
}
if (!(priv->config & CFG_ASSOCIATE) &&
- !(priv->config & (CFG_STATIC_ESSID |
- CFG_STATIC_CHANNEL | CFG_STATIC_BSSID))) {
+ !(priv->config & (CFG_STATIC_ESSID | CFG_STATIC_BSSID))) {
IPW_DEBUG_ASSOC("Not attempting association (associate=0)\n");
return 0;
}
--
1.5.6.3
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2008-11-06 8:51 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-11-05 8:45 [PATCH] ipw2200: make assocaittion only if SSID is known Alexey Fisher
[not found] ` <1225874758-5948-1-git-send-email-bug-track-M18mAb7Tlt0yCq4wW13eYl6hYfS7NtTn@public.gmane.org>
2008-11-06 1:03 ` Zhu Yi
-- strict thread matches above, loose matches on Subject: below --
2008-11-06 8:51 Alexey Fisher
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).