kernel-testers.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Mel Gorman <mel@csn.ul.ie>
To: Andrew Morton <akpm@linux-foundation.org>, stable@kernel.org
Cc: linux-kernel@vger.kernel.org,
	"linux-mm@kvack.org\"" <linux-mm@kvack.org>,
	Frans Pop <elendil@planet.nl>, Jiri Kosina <jkosina@suse.cz>,
	Sven Geggus <lists@fuchsschwanzdomain.de>,
	Karol Lewandowski <karol.k.lewandowski@gmail.com>,
	Tobias Oetiker <tobi@oetiker.ch>,
	KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>,
	Pekka Enberg <penberg@cs.helsinki.fi>,
	Rik van Riel <riel@redhat.com>,
	Christoph Lameter <cl@linux-foundation.org>,
	Stephan von Krawczynski <skraw@ithnet.com>,
	"Rafael J. Wysocki" <rjw@sisk.pl>,
	Kernel Testers List <kernel-testers@vger.kernel.org>,
	Mel Gorman <mel@csn.ul.ie>
Subject: [PATCH 2/3] page allocator: Do not allow interrupts to use ALLOC_HARDER
Date: Tue, 27 Oct 2009 13:40:32 +0000	[thread overview]
Message-ID: <1256650833-15516-3-git-send-email-mel@csn.ul.ie> (raw)
In-Reply-To: <1256650833-15516-1-git-send-email-mel@csn.ul.ie>

Commit 341ce06f69abfafa31b9468410a13dbd60e2b237 altered watermark logic
slightly by allowing rt_tasks that are handling an interrupt to set
ALLOC_HARDER. This patch brings the watermark logic more in line with
2.6.30.

[rientjes@google.com: Spotted the problem]
Signed-off-by: Mel Gorman <mel@csn.ul.ie>
Reviewed-by: Pekka Enberg <penberg@cs.helsinki.fi>
Reviewed-by: Rik van Riel <riel@redhat.com>
Reviewed-by: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
---
 mm/page_alloc.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/mm/page_alloc.c b/mm/page_alloc.c
index dfa4362..7f2aa3e 100644
--- a/mm/page_alloc.c
+++ b/mm/page_alloc.c
@@ -1769,7 +1769,7 @@ gfp_to_alloc_flags(gfp_t gfp_mask)
 		 * See also cpuset_zone_allowed() comment in kernel/cpuset.c.
 		 */
 		alloc_flags &= ~ALLOC_CPUSET;
-	} else if (unlikely(rt_task(p)))
+	} else if (unlikely(rt_task(p)) && !in_interrupt())
 		alloc_flags |= ALLOC_HARDER;
 
 	if (likely(!(gfp_mask & __GFP_NOMEMALLOC))) {
-- 
1.6.3.3

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  parent reply	other threads:[~2009-10-27 13:40 UTC|newest]

Thread overview: 45+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-10-27 13:40 [PATCH 0/3] Reduce GFP_ATOMIC allocation failures, partial fix V3 Mel Gorman
     [not found] ` <1256650833-15516-1-git-send-email-mel-wPRd99KPJ+uzQB+pC5nmwQ@public.gmane.org>
2009-10-27 13:40   ` [PATCH 1/3] page allocator: Always wake kswapd when restarting an allocation attempt after direct reclaim failed Mel Gorman
2009-10-28 13:02   ` [PATCH 0/3] Reduce GFP_ATOMIC allocation failures, partial fix V3 Karol Lewandowski
2009-10-27 13:40 ` Mel Gorman [this message]
     [not found]   ` <1256650833-15516-3-git-send-email-mel-wPRd99KPJ+uzQB+pC5nmwQ@public.gmane.org>
2009-10-27 20:09     ` [PATCH 2/3] page allocator: Do not allow interrupts to use ALLOC_HARDER Andrew Morton
     [not found]       ` <20091027130924.fa903f5a.akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org>
2009-10-27 21:12         ` David Rientjes
     [not found]           ` <alpine.DEB.2.00.0910271411530.9183-X6Q0R45D7oAcqpCFd4KODRPsWskHk0ljAL8bYrjMMd8@public.gmane.org>
2009-10-31 18:40             ` Pavel Machek
2009-10-31 19:51               ` David Rientjes
2009-10-31 20:11                 ` Pavel Machek
     [not found]                   ` <20091031201158.GB29536-I/5MKhXcvmPrBKCeMvbIDA@public.gmane.org>
2009-10-31 21:19                     ` David Rientjes
2009-10-31 22:29                       ` Pavel Machek
2009-10-31 22:55                         ` Rik van Riel
     [not found]                           ` <4AECC04B.9060808-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2009-11-01  7:35                             ` Pavel Machek
     [not found]                               ` <20091101073527.GB32720-I/5MKhXcvmPrBKCeMvbIDA@public.gmane.org>
2009-11-01 12:37                                 ` KOSAKI Motohiro
2009-11-01 14:44                               ` Rik van Riel
     [not found]                                 ` <4AED9EB4.5080601-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2009-11-01 19:32                                   ` Pavel Machek
2009-11-02 16:38                                 ` Christoph Lameter
2009-10-31 23:59                   ` Rik van Riel
2009-11-02 16:42                     ` Christoph Lameter
2009-11-02 20:53                       ` David Rientjes
2009-11-03 17:10                         ` Christoph Lameter
2009-11-04  1:46                           ` David Rientjes
     [not found]                             ` <alpine.DEB.2.00.0911031739380.1187-X6Q0R45D7oAcqpCFd4KODRPsWskHk0ljAL8bYrjMMd8@public.gmane.org>
2009-11-04  9:01                               ` Pavel Machek
     [not found]                                 ` <20091104090140.GA14694-I/5MKhXcvmPrBKCeMvbIDA@public.gmane.org>
2009-11-09 10:11                                   ` Mel Gorman
2009-10-27 13:40 ` [PATCH 3/3] vmscan: Force kswapd to take notice faster when high-order watermarks are being hit Mel Gorman
     [not found]   ` <1256650833-15516-4-git-send-email-mel-wPRd99KPJ+uzQB+pC5nmwQ@public.gmane.org>
2009-10-27 18:18     ` Rik van Riel
2009-10-27 20:19   ` Andrew Morton
     [not found]     ` <20091027131905.410ec04a.akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org>
2009-10-28  3:54       ` KOSAKI Motohiro
2009-10-28 10:29       ` Mel Gorman
2009-10-28 19:47         ` Andrew Morton
     [not found]           ` <20091028124756.7af44b6b.akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org>
2009-11-02 16:05             ` Mel Gorman
2009-11-02 17:32               ` Frans Pop
     [not found]                 ` <200911021832.59035.elendil-EIBgga6/0yRmR6Xm/wNWPw@public.gmane.org>
2009-11-02 17:38                   ` Mel Gorman
2009-11-02 20:36                     ` Mel Gorman
2009-11-03 22:01                     ` Frans Pop
     [not found]                       ` <200911032301.59662.elendil-EIBgga6/0yRmR6Xm/wNWPw@public.gmane.org>
2009-11-03 22:08                         ` Mel Gorman
2009-11-04  0:01                           ` Frans Pop
2009-11-04  1:18                             ` Mel Gorman
     [not found]                               ` <20091104011811.GG22046-wPRd99KPJ+uzQB+pC5nmwQ@public.gmane.org>
2009-11-04  2:05                                 ` Frans Pop
2009-11-04  2:08                                   ` Frans Pop
     [not found]                                   ` <200911040305.59352.elendil-EIBgga6/0yRmR6Xm/wNWPw@public.gmane.org>
2009-11-04 15:48                                     ` Mel Gorman
     [not found]                                       ` <20091104154853.GM22046-wPRd99KPJ+uzQB+pC5nmwQ@public.gmane.org>
2009-11-04 20:57                                         ` Frans Pop
     [not found]                                           ` <200911042157.25020.elendil-EIBgga6/0yRmR6Xm/wNWPw@public.gmane.org>
2009-11-05 16:48                                             ` [PATCH 3/3] vmscan: Force kswapd to take notice faster when high-order watermarks are being hit (data on latencies available) Mel Gorman
     [not found]                                               ` <20091105164832.GB25926-wPRd99KPJ+uzQB+pC5nmwQ@public.gmane.org>
2009-11-12 11:36                                                 ` Frans Pop
2009-11-04  2:08                                 ` [PATCH 3/3] vmscan: Force kswapd to take notice faster when high-order watermarks are being hit Mel Gorman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1256650833-15516-3-git-send-email-mel@csn.ul.ie \
    --to=mel@csn.ul.ie \
    --cc=akpm@linux-foundation.org \
    --cc=cl@linux-foundation.org \
    --cc=elendil@planet.nl \
    --cc=jkosina@suse.cz \
    --cc=karol.k.lewandowski@gmail.com \
    --cc=kernel-testers@vger.kernel.org \
    --cc=kosaki.motohiro@jp.fujitsu.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=lists@fuchsschwanzdomain.de \
    --cc=penberg@cs.helsinki.fi \
    --cc=riel@redhat.com \
    --cc=rjw@sisk.pl \
    --cc=skraw@ithnet.com \
    --cc=stable@kernel.org \
    --cc=tobi@oetiker.ch \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).