From mboxrd@z Thu Jan 1 00:00:00 1970 From: Benjamin Herrenschmidt Subject: Re: Help needed, Re: [Bug #14334] pcmcia suspend regression from 2.6.31.1 to 2.6.31.2 - Dell Inspiron 600m Date: Tue, 03 Nov 2009 09:22:03 +1100 Message-ID: <1257200523.7907.53.camel@pasglop> References: <200911010936.10409.rjw@sisk.pl> <200911021439.28266.rjw@sisk.pl> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <200911021439.28266.rjw-KKrjLPT3xs0@public.gmane.org> Sender: kernel-testers-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-ID: Content-Type: text/plain; charset="us-ascii" To: "Rafael J. Wysocki" Cc: Linus Torvalds , Linux Kernel Mailing List , Kernel Testers List , Greg Kroah-Hartman , Jose Marino , ACPI Devel Maling List , Linux PCI , Dominik Brodowski On Mon, 2009-11-02 at 14:39 +0100, Rafael J. Wysocki wrote: > > > That socket _is_ going to be suspended, and testing for it here just seems > > to confuse things. > > > > So I'd remove it from both early_resume and late_resume, and only keep it > > in the case of the legacy user-requested suspend/resume (do we even do > > that any more?). > > OK, updated patch is appended. Test by me delayed to tomorrow ... hit another suspend/resume bug on that laptop which took away the time I had to do that test yesterday and today I'm off :-) (Bug was simple but took a while to track down: machine was left in storage for a while, battery ran out, RTC went back to Jan 1, 1904, which means a negative xtime, and the new timekeeping code will do horrible things including hanging at resume when that happens. Fix is to make powerpc read_persistent_clock() to ignore the RTC when it contains a date older than epoch). Cheers, Ben.