* [PATCH] Input: colibri-vf50-ts: fix implicit declaration
@ 2016-02-10 9:45 Sudip Mukherjee
2016-02-10 9:54 ` Geert Uytterhoeven
0 siblings, 1 reply; 3+ messages in thread
From: Sudip Mukherjee @ 2016-02-10 9:45 UTC (permalink / raw)
To: Dmitry Torokhov, Sanchayan Maity
Cc: linux-kernel-u79uwXL29TY76Z2rM5mHXA,
kernel-testers-u79uwXL29TY76Z2rM5mHXA,
linux-input-u79uwXL29TY76Z2rM5mHXA, Sudip Mukherjee,
Geert Uytterhoeven
The build of m32r allmodconfig fails with the error:
drivers/input/touchscreen/colibri-vf50-ts.c:302:10: error: implicit
declaration of function 'of_property_read_u32'
of_property_read_u32() is defined in linux/of.h which was not included.
Fixes: 1261d013daea ("Input: Allow compile test of Goodix and Colibri VF50 if !GPIOLIB")
Cc: Geert Uytterhoeven <geert-Td1EMuHUCqxL1ZNQvxDV9g@public.gmane.org>
Signed-off-by: Sudip Mukherjee <sudip-ofJRbWXBVFamYgehrs7/Lw@public.gmane.org>
---
drivers/input/touchscreen/colibri-vf50-ts.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/input/touchscreen/colibri-vf50-ts.c b/drivers/input/touchscreen/colibri-vf50-ts.c
index 5d4903a..594c096 100644
--- a/drivers/input/touchscreen/colibri-vf50-ts.c
+++ b/drivers/input/touchscreen/colibri-vf50-ts.c
@@ -25,6 +25,7 @@
#include <linux/platform_device.h>
#include <linux/slab.h>
#include <linux/types.h>
+#include <linux/of.h>
#define DRIVER_NAME "colibri-vf50-ts"
#define DRV_VERSION "1.0"
--
1.9.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] Input: colibri-vf50-ts: fix implicit declaration
2016-02-10 9:45 [PATCH] Input: colibri-vf50-ts: fix implicit declaration Sudip Mukherjee
@ 2016-02-10 9:54 ` Geert Uytterhoeven
[not found] ` <CAMuHMdVViFX+0Wi_LBFsjFStEZnX1XNG-n8tj6qug3mSioySag-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
0 siblings, 1 reply; 3+ messages in thread
From: Geert Uytterhoeven @ 2016-02-10 9:54 UTC (permalink / raw)
To: Sudip Mukherjee
Cc: Dmitry Torokhov, Sanchayan Maity, linux-kernel@vger.kernel.org,
kernel-testers, linux-input@vger.kernel.org
On Wed, Feb 10, 2016 at 10:45 AM, Sudip Mukherjee
<sudipm.mukherjee@gmail.com> wrote:
> The build of m32r allmodconfig fails with the error:
> drivers/input/touchscreen/colibri-vf50-ts.c:302:10: error: implicit
> declaration of function 'of_property_read_u32'
>
> of_property_read_u32() is defined in linux/of.h which was not included.
>
> Fixes: 1261d013daea ("Input: Allow compile test of Goodix and Colibri VF50 if !GPIOLIB")
Actually I had sent the exact same patch to add this missing include,
to apply before 1261d013daea, but it seems Dmitry only applied the
second one.
http://permalink.gmane.org/gmane.linux.kernel.gpio/14086
> Cc: Geert Uytterhoeven <geert@linux-m68k.org>
> Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org>
> ---
> drivers/input/touchscreen/colibri-vf50-ts.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/input/touchscreen/colibri-vf50-ts.c b/drivers/input/touchscreen/colibri-vf50-ts.c
> index 5d4903a..594c096 100644
> --- a/drivers/input/touchscreen/colibri-vf50-ts.c
> +++ b/drivers/input/touchscreen/colibri-vf50-ts.c
> @@ -25,6 +25,7 @@
> #include <linux/platform_device.h>
> #include <linux/slab.h>
> #include <linux/types.h>
> +#include <linux/of.h>
Gr{oetje,eeting}s,
Geert
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-02-10 10:04 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-02-10 9:45 [PATCH] Input: colibri-vf50-ts: fix implicit declaration Sudip Mukherjee
2016-02-10 9:54 ` Geert Uytterhoeven
[not found] ` <CAMuHMdVViFX+0Wi_LBFsjFStEZnX1XNG-n8tj6qug3mSioySag-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-02-10 10:04 ` Sudip Mukherjee
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).