kernel-testers.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] s390: fix build failure
@ 2016-04-01 12:35 Sudip Mukherjee
       [not found] ` <1459514116-24505-1-git-send-email-sudipm.mukherjee-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
  0 siblings, 1 reply; 2+ messages in thread
From: Sudip Mukherjee @ 2016-04-01 12:35 UTC (permalink / raw)
  To: Martin Schwidefsky, Heiko Carstens
  Cc: linux-kernel-u79uwXL29TY76Z2rM5mHXA,
	kernel-testers-u79uwXL29TY76Z2rM5mHXA,
	linux-s390-u79uwXL29TY76Z2rM5mHXA, Sudip Mukherjee, Matt Redfearn

s390 defconfig and allmodconfig fails with the error:
kernel/seccomp.c: In function '__secure_computing_strict':
kernel/seccomp.c:526:3: error: implicit declaration of function
				'get_compat_mode1_syscalls'

The retrieval of compat syscall numbers were moved into inline function
defined in asm-generic header but the asm-generic header was not being
used by s390.

Fixes: 5adddb612ca1 ("seccomp: Get compat syscalls from asm-generic header")
Cc: Matt Redfearn <matt.redfearn-1AXoQHu6uovQT0dZR+AlfA@public.gmane.org>
Signed-off-by: Sudip Mukherjee <sudip.mukherjee-4yDnlxn2s6sWdaTGBSpHTA@public.gmane.org>
---

Tested with s390 defconfig and allmodconfig build.
Build logs of next-20160401 are at:
https://travis-ci.org/sudipm-mukherjee/parport/jobs/119983952 (allmodconfig)
and
https://travis-ci.org/sudipm-mukherjee/parport/jobs/119983909 (defconfig)

 arch/s390/include/asm/seccomp.h | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/arch/s390/include/asm/seccomp.h b/arch/s390/include/asm/seccomp.h
index 781a9cf..e10f833 100644
--- a/arch/s390/include/asm/seccomp.h
+++ b/arch/s390/include/asm/seccomp.h
@@ -13,4 +13,6 @@
 #define __NR_seccomp_exit_32	__NR_exit
 #define __NR_seccomp_sigreturn_32 __NR_sigreturn
 
+#include <asm-generic/seccomp.h>
+
 #endif	/* _ASM_S390_SECCOMP_H */
-- 
2.1.4

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] s390: fix build failure
       [not found] ` <1459514116-24505-1-git-send-email-sudipm.mukherjee-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
@ 2016-04-01 14:02   ` Heiko Carstens
  0 siblings, 0 replies; 2+ messages in thread
From: Heiko Carstens @ 2016-04-01 14:02 UTC (permalink / raw)
  To: Sudip Mukherjee
  Cc: Martin Schwidefsky, linux-kernel-u79uwXL29TY76Z2rM5mHXA,
	kernel-testers-u79uwXL29TY76Z2rM5mHXA,
	linux-s390-u79uwXL29TY76Z2rM5mHXA, Matt Redfearn

On Fri, Apr 01, 2016 at 01:35:16PM +0100, Sudip Mukherjee wrote:
> s390 defconfig and allmodconfig fails with the error:
> kernel/seccomp.c: In function '__secure_computing_strict':
> kernel/seccomp.c:526:3: error: implicit declaration of function
> 				'get_compat_mode1_syscalls'
> 
> The retrieval of compat syscall numbers were moved into inline function
> defined in asm-generic header but the asm-generic header was not being
> used by s390.
> 
> Fixes: 5adddb612ca1 ("seccomp: Get compat syscalls from asm-generic header")
> Cc: Matt Redfearn <matt.redfearn-1AXoQHu6uovQT0dZR+AlfA@public.gmane.org>
> Signed-off-by: Sudip Mukherjee <sudip.mukherjee-4yDnlxn2s6sWdaTGBSpHTA@public.gmane.org>
> ---
> 
> Tested with s390 defconfig and allmodconfig build.
> Build logs of next-20160401 are at:
> https://travis-ci.org/sudipm-mukherjee/parport/jobs/119983952 (allmodconfig)
> and
> https://travis-ci.org/sudipm-mukherjee/parport/jobs/119983909 (defconfig)
> 
>  arch/s390/include/asm/seccomp.h | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/arch/s390/include/asm/seccomp.h b/arch/s390/include/asm/seccomp.h
> index 781a9cf..e10f833 100644
> --- a/arch/s390/include/asm/seccomp.h
> +++ b/arch/s390/include/asm/seccomp.h
> @@ -13,4 +13,6 @@
>  #define __NR_seccomp_exit_32	__NR_exit
>  #define __NR_seccomp_sigreturn_32 __NR_sigreturn
> 
> +#include <asm-generic/seccomp.h>
> +
>  #endif	/* _ASM_S390_SECCOMP_H */

Applied with a modified changelog, since it makes sense anyway to include
the generic header file.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2016-04-01 14:02 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-04-01 12:35 [PATCH] s390: fix build failure Sudip Mukherjee
     [not found] ` <1459514116-24505-1-git-send-email-sudipm.mukherjee-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2016-04-01 14:02   ` Heiko Carstens

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).