From: Ingo Molnar <mingo@elte.hu>
To: Vegard Nossum <vegard.nossum@gmail.com>
Cc: Daniel J Blueman <daniel.blueman@gmail.com>,
Thomas Gleixner <tglx@linutronix.de>,
Christoph Lameter <clameter@sgi.com>,
Linus Torvalds <torvalds@linux-foundation.org>,
"Rafael J. Wysocki" <rjw@sisk.pl>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Adrian Bunk <bunk@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Natalie Protasevich <protasnb@gmail.com>,
Kernel Testers List <kernel-testers@vger.kernel.org>
Subject: Re: SLUB/debugobjects locking (Re: 2.6.27-rc4-git1: Reported regressions from 2.6.26)
Date: Thu, 28 Aug 2008 15:56:59 +0200 [thread overview]
Message-ID: <20080828135659.GA1929@elte.hu> (raw)
In-Reply-To: <19f34abd0808280642j529eab2ct17722644d1550ad9@mail.gmail.com>
* Vegard Nossum <vegard.nossum@gmail.com> wrote:
> On Wed, Aug 27, 2008 at 12:14 AM, Daniel J Blueman
> <daniel.blueman@gmail.com> wrote:
> > On Mon, Aug 25, 2008 at 8:44 PM, Vegard Nossum <vegard.nossum@gmail.com> wrote:
> >> I tried your suggestion of promoting the lock to irq-safe, and it
> >> fixed the warning for me (didn't get or look for deadlocks yet, but it
> >> seems likely that it is caused by the same thing?), the patch is
> >> attached for reference.
> >>
> >> I also don't know if this is the best fix, but I also don't have any
> >> other (better) suggestions.
> >>
> >> Others are welcome to pick it up from here...
> >
> > The solution looks like is needs to get the lock ordering correct
> > w.r.t. SLUB, as we get this, alas:
> >
> > =======================================================
> > [ INFO: possible circular locking dependency detected ]
> > 2.6.27-rc4-229c-debug #1
>
> Hm. Is this with my first patch + the one in the e-mail you replied
> to? It was intended to be a delta patch on top of my first one.
>
> That would be the one in
>
> http://marc.info/?l=linux-kernel&m=121946972307110&w=4
>
> plus the one in
>
> http://marc.info/?l=linux-kernel&m=121969394110327&w=1
>
> Thanks for testing and sorry for the confusion. (Maybe I just confused
> myself. Please let me know either way.)
could you resend the final patch please? It's a candidate for .27, if it
works out fine.
Ingo
prev parent reply other threads:[~2008-08-28 13:56 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-25 19:44 SLUB/debugobjects locking (Re: 2.6.27-rc4-git1: Reported regressions from 2.6.26) Vegard Nossum
[not found] ` <19f34abd0808251244v439e78b1hbb24f77c637559c3-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2008-08-26 22:14 ` Daniel J Blueman
[not found] ` <6278d2220808261514p2661251aw914215652c547125-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2008-08-28 13:42 ` Vegard Nossum
2008-08-28 13:56 ` Ingo Molnar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080828135659.GA1929@elte.hu \
--to=mingo@elte.hu \
--cc=akpm@linux-foundation.org \
--cc=bunk@kernel.org \
--cc=clameter@sgi.com \
--cc=daniel.blueman@gmail.com \
--cc=kernel-testers@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=protasnb@gmail.com \
--cc=rjw@sisk.pl \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
--cc=vegard.nossum@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).