From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Paul E. McKenney" Subject: Re: [Bug #11989] Suspend failure on NForce4-based boards due to chanes in stop_machine Date: Wed, 12 Nov 2008 11:43:46 -0800 Message-ID: <20081112194346.GF6667@linux.vnet.ibm.com> References: <20081111113134.GA5653@osiris.boeblingen.de.ibm.com> <20081111124201.GA9459@osiris.boeblingen.de.ibm.com> <20081111143505.GA6923@linux.vnet.ibm.com> <20081111150225.GA10743@linux.vnet.ibm.com> <20081111161401.GC9459@osiris.boeblingen.de.ibm.com> <20081111164523.GB6736@linux.vnet.ibm.com> <20081111173451.GA24720@linux.vnet.ibm.com> <20081112090508.GA14329@osiris.boeblingen.de.ibm.com> <20081112160349.GA6667@linux.vnet.ibm.com> <20081112165118.GA30743@osiris.boeblingen.de.ibm.com> Reply-To: paulmck-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org Mime-Version: 1.0 Return-path: Content-Disposition: inline In-Reply-To: <20081112165118.GA30743-Pmgahw53EmNLmI7Nx2oIsGnsbthNF6/HVpNB7YpNyf8@public.gmane.org> Sender: kernel-testers-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-ID: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Heiko Carstens Cc: Ingo Molnar , "Rafael J. Wysocki" , Linux Kernel Mailing List , Kernel Testers List , Rusty Russell , Vegard Nossum , Peter Zijlstra , Oleg Nesterov , Dmitry Adamushko , Andrew Morton , Steven Rostedt , manfred-nhLOkwUX5cPe2c5cEj3t2g@public.gmane.org On Wed, Nov 12, 2008 at 05:51:18PM +0100, Heiko Carstens wrote: > On Wed, Nov 12, 2008 at 08:03:49AM -0800, Paul E. McKenney wrote: > > On Wed, Nov 12, 2008 at 10:05:08AM +0100, Heiko Carstens wrote: > > > On Tue, Nov 11, 2008 at 09:34:51AM -0800, Paul E. McKenney wrote: > > > > > Were you using preemptible RCU earlier as well? Raphael was using > > > > > classic RCU. Don't get me wrong, all problems need fixing, just trying > > > > > to make sure I understand where the problems are occurring. > > > > > > Indeed, my fault. I just try to reproduce a cpu hotplug bug with classic RCU > > > and cpu hotplug stress test, but no luck so far. > > > > OK, then my next step will be to send Rafael an updated version of > > my hierarchical RCU, which is more robust than classic RCU against > > online/offline stress tests. On the machines I have access to, anyway. ;-) > > > > Then I will look at preemptable RCU, which undoubtably needs some of the > > same help that I have been giving to hierarchical RCU. Manfred thus > > wins the clairvoyance award! > > Well, I tried all day long to reproduce a cpu hotplug/stop_machine hang > with classic RCU and a kernel configuration that is as close as possible > to Raphael's configuration, but it just continues to work without a bug. > > One of the machines is a virtual machine with 8 virtual cpus mapped on > two real cpus. The real cpus are again shared with other guests. So I end > up with cpu steal times of 50-90%. That should have revealed races in the > stop_machine code, considering that thousands of cpu hotplug operations > happened. > > I let these test machines running over night. Maybe something happens... > but at a first glance it looks more like the reworked stop_machine code > triggers a different bug that already is present. Hmmm... I can make Classic RCU break in 2.6.28-rc3, but I need a 128-CPU machine to break it. ;-) Thanx, Paul