From: Dave Chinner <david-FqsqvQoI3Ljby3iVrkZq2A@public.gmane.org>
To: Alexander Beregalov
<a.beregalov-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: Christoph Hellwig <hch-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>,
xfs-masters-VZNHf3L845pBDgjK7y7TUQ@public.gmane.org,
xfs-VZNHf3L845pBDgjK7y7TUQ@public.gmane.org,
kernel-testers-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [xfs-masters] 2.6.29-rc: kernel BUG at fs/xfs/support/debug.c:108
Date: Mon, 12 Jan 2009 14:45:50 +1100 [thread overview]
Message-ID: <20090112034550.GI8071@disturbed> (raw)
In-Reply-To: <a4423d670901111648w26e86baajcf7b6d98ff37d043-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
On Mon, Jan 12, 2009 at 03:48:13AM +0300, Alexander Beregalov wrote:
> > Hmmmm - this might be getting closer to the source of the bug.
> > It's being detecting when reading in the buffer to do a left shift
> > now, not during the delete of a record.
> >
> > I'd suggest that you treat this as the same failure and continue
> > the bisect to try to find when no problems show up at all.
>
> 687b890a184fef263ebb773926e1f4aa69240d01 is the first bad commit.
[XFS] implement generic xfs_btree_lshift
Make the btree left shift code generic. Based on a patch from David
Chinner with lots of changes to follow the original btree implementations
more closely. While this loses some of the generic helper routines for
inserting/moving/removing records it also solves some of the one off bugs
in the original code and makes it easier to verify.
> Does it make sense?
Yes, a bug in that patch could corrupt the btree in memory which we then trip
over later in delrec before it has been written to disk.
Thank you for isolating the problem to that commit - it greatly narrows down
the amount of code we need to search to find the bug. I'll have a look tonight
to see if I can spot the problem.
Cheers,
Dave.
--
Dave Chinner
david-FqsqvQoI3Ljby3iVrkZq2A@public.gmane.org
next prev parent reply other threads:[~2009-01-12 3:45 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-09 4:41 2.6.29-rc: kernel BUG at fs/xfs/support/debug.c:108 Alexander Beregalov
2009-01-09 5:38 ` [xfs-masters] " Dave Chinner
2009-01-09 21:53 ` Alexander Beregalov
[not found] ` <a4423d670901091353s7ff12207gcb38eb093d77d401-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2009-01-09 22:18 ` Alexander Beregalov
[not found] ` <a4423d670901091418j5c7fdfb2oeba2f4640f8e29d0-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2009-01-09 23:11 ` Alexander Beregalov
[not found] ` <a4423d670901091511y68a53808rfaab8148526224c6-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2009-01-10 12:19 ` Alexander Beregalov
[not found] ` <a4423d670901100419s2ae106bexac1a538caf654153-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2009-01-10 14:39 ` Christoph Hellwig
[not found] ` <20090110143924.GA25900-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>
2009-01-10 15:09 ` Alexander Beregalov
[not found] ` <a4423d670901100709v1e7ce0bfs167547c5001787ac-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2009-01-10 15:28 ` Christoph Hellwig
[not found] ` <20090110152803.GA7469-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>
2009-01-10 22:14 ` Alexander Beregalov
2009-01-11 10:46 ` Dave Chinner
2009-01-12 0:48 ` Alexander Beregalov
[not found] ` <a4423d670901111648w26e86baajcf7b6d98ff37d043-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2009-01-12 2:19 ` Alexander Beregalov
2009-01-12 3:45 ` Dave Chinner [this message]
2009-01-12 8:08 ` Alexander Beregalov
[not found] ` <a4423d670901120008j728af9cdrbed8bbb938117ea3-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2009-01-12 21:18 ` Dave Chinner
2009-01-20 18:54 ` Alexander Beregalov
[not found] ` <a4423d670901201054t3e48ece2ned4a7e3254250fce-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2009-01-20 19:33 ` Eric Sandeen
2009-01-20 20:33 ` Christoph Hellwig
[not found] ` <20090120203319.GA7103-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>
2009-01-23 18:34 ` Alexander Beregalov
[not found] ` <a4423d670901231034k6971ed91tbed3d6eab05d7285-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2009-01-24 3:22 ` Christoph Hellwig
2009-01-10 16:27 ` Eric Sandeen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090112034550.GI8071@disturbed \
--to=david-fqsqvqoi3ljby3ivrkzq2a@public.gmane.org \
--cc=a.beregalov-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=hch-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org \
--cc=kernel-testers-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=xfs-VZNHf3L845pBDgjK7y7TUQ@public.gmane.org \
--cc=xfs-masters-VZNHf3L845pBDgjK7y7TUQ@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).