kernel-testers.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Arjan van de Ven <arjan@infradead.org>
To: Bjorn Helgaas <bjorn.helgaas@hp.com>
Cc: Alan Jenkins <alan-jenkins@tuffmail.co.uk>,
	linux-acpi@vger.kernel.org,
	linux-kernel <linux-kernel@vger.kernel.org>,
	Kernel Testers List <kernel-testers@vger.kernel.org>,
	Venkatesh Pallipadi <venkatesh.pallipadi@intel.com>
Subject: Re: [BISECTED] EEE PC hangs when booting off battery
Date: Tue, 14 Apr 2009 08:17:28 -0700	[thread overview]
Message-ID: <20090414081728.10de978a@infradead.org> (raw)
In-Reply-To: <200904140859.02188.bjorn.helgaas@hp.com>

On Tue, 14 Apr 2009 08:59:01 -0600
Bjorn Helgaas <bjorn.helgaas@hp.com> wrote:

> I can't help with the real problem of why the asynchronous battery
> init causes the hang.

that got fixed already for the module case.

> 
> But I do object to the magic makefile ordering change in that commit.
> Nobody reading the makefile can tell why battery is down at the end,
> and moving it apparently slows down boot significantly. 

for all cases I've seen it actually speeds it up, because the battery
now runs concurrently with the disk probe.

> So the
> ordering change just feels like a band-aid that covers up a place
> where ACPI could be improved.

the reason for the move is that both the battery and other pieces take
the big acpi lock; which defeats the parallelism. So the battery needs
to happen at the end instead.

-- 
Arjan van de Ven 	Intel Open Source Technology Centre
For development, discussion and tips for power savings, 
visit http://www.lesswatts.org

  reply	other threads:[~2009-04-14 15:17 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-04-11  9:41 Regression: EEE PC hangs when booting off battery Alan Jenkins
     [not found] ` <49E065CF.6040408-cCz0Lq7MMjm9FHfhHBbuYA@public.gmane.org>
2009-04-11 18:07   ` Tzy-Jye Daniel Lin
     [not found]     ` <66dc75180904111107q645fbb77i3cf927ffab7a7ef0-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2009-04-12  9:00       ` Alan Jenkins
     [not found]         ` <49E1ADAE.2030103-cCz0Lq7MMjm9FHfhHBbuYA@public.gmane.org>
2009-04-12 13:11           ` [BISECTED] " Alan Jenkins
     [not found]             ` <49E1E89D.7040502-cCz0Lq7MMjm9FHfhHBbuYA@public.gmane.org>
2009-04-13 19:15               ` Bjorn Helgaas
     [not found]                 ` <200904131315.55519.bjorn.helgaas-VXdhtT5mjnY@public.gmane.org>
2009-04-13 19:57                   ` Alan Jenkins
2009-04-13 22:28                     ` Bjorn Helgaas
2009-04-14  8:06                       ` Alan Jenkins
2009-04-14  9:26                         ` Alan Jenkins
2009-04-14 14:59                           ` Bjorn Helgaas
2009-04-14 15:17                             ` Arjan van de Ven [this message]
2009-04-14 15:37                               ` Alan Jenkins
     [not found]                               ` <20090414081728.10de978a-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>
2009-04-14 15:48                                 ` Bjorn Helgaas
     [not found]                                   ` <200904140948.37633.bjorn.helgaas-VXdhtT5mjnY@public.gmane.org>
2009-04-14 15:55                                     ` Moore, Robert
     [not found]                                       ` <4911F71203A09E4D9981D27F9D8308581D3722EB-osO9UTpF0URQxe9IK+vIArfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2009-04-14 16:56                                         ` Bjorn Helgaas
2009-04-14 17:22                                           ` Moore, Robert
     [not found]                                             ` <4911F71203A09E4D9981D27F9D8308581D372489-osO9UTpF0URQxe9IK+vIArfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2009-04-14 17:28                                               ` Alan Jenkins
     [not found]                                           ` <200904141056.14159.bjorn.helgaas-VXdhtT5mjnY@public.gmane.org>
2009-04-15 15:38                                             ` Len Brown
2009-04-15 14:32                                     ` [FIXED] " Alan Jenkins
2009-04-22 12:17                                       ` Alan Jenkins
2009-04-26 11:34                                         ` Alan Jenkins
     [not found]                                           ` <49F446AE.6070607-cCz0Lq7MMjm9FHfhHBbuYA@public.gmane.org>
2009-04-28  9:19                                             ` [PATCH] [RFC] " Alan Jenkins
     [not found]                                               ` <49F6CA0E.5040101-cCz0Lq7MMjm9FHfhHBbuYA@public.gmane.org>
2009-04-28  9:58                                                 ` Johannes Berg
     [not found]                                                   ` <1240912688.28835.10.camel-YfaajirXv2244ywRPIzf9A@public.gmane.org>
2009-04-28 10:27                                                     ` Alan Jenkins
     [not found]                                                       ` <49F6DA14.7030608-cCz0Lq7MMjm9FHfhHBbuYA@public.gmane.org>
2009-04-28 10:35                                                         ` Johannes Berg
2009-04-29 11:14                                                         ` Alan Jenkins
     [not found]                                                           ` <49F83699.3000307-cCz0Lq7MMjm9FHfhHBbuYA@public.gmane.org>
2009-04-29 11:20                                                             ` Johannes Berg
2009-05-15 21:48                                                             ` Rafael J. Wysocki
     [not found]                                                               ` <200905152348.56449.rjw-KKrjLPT3xs0@public.gmane.org>
2009-05-16  8:39                                                                 ` Alan Jenkins
2009-04-11 19:40 ` Regression: " Kristoffer Ericson
     [not found]   ` <20090411214045.7bdd497f.kristoffer.ericson-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2009-04-12  9:22     ` Alan Jenkins
2009-04-15 15:49       ` archlinux 2.6.28 ac oops (was Re: Regression: EEE PC hangs when booting off battery) Len Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090414081728.10de978a@infradead.org \
    --to=arjan@infradead.org \
    --cc=alan-jenkins@tuffmail.co.uk \
    --cc=bjorn.helgaas@hp.com \
    --cc=kernel-testers@vger.kernel.org \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=venkatesh.pallipadi@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).