From: Mathieu Desnoyers <mathieu.desnoyers-scC8bbJcJLCw5LPnMra/2Q@public.gmane.org>
To: linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Venkatesh Pallipadi
<venkatesh.pallipadi-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>,
Dave Jones <davej-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>,
Thomas Renninger <trenn-l3A5Bk7waGM@public.gmane.org>,
cpufreq-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, kernel-te
Subject: [patch 2.6.30 0/4] Fix cpufreq locking dependency (resend)
Date: Fri, 03 Jul 2009 11:25:14 -0400 [thread overview]
Message-ID: <20090703152514.903448283@polymtl.ca> (raw)
(sorry, quilt mail problems in the previous post, here is the resend)
Hi,
Here is a patchset applying on 2.6.30 which should fix the cpufreq locking
dependency. Sadly, my two main test machines does not seem to support cpufreq,
so I have only been able to perform very light testing. (I can't afford to lock
down my laptop right now).
I went for the most straightforward fix I could think of and kept the current
locking structure. As you will see, the second patch cleans up the error
handling paths of cpufreq add dev, which were a total mess.
As a general recommendation, creating scripts which does, concurrently :
cpu hotplug up/down
cpufreq sysfs actions
change between cpufreq governors
add governors on random CPU numbers
will likely help stress-testing cpufreq locking. I really did not like what I've
seen there. It looked _very_ fragile.
Hopefully this will be better with this patches, but again, testing is welcome.
Thanks,
Mathieu
--
Mathieu Desnoyers
OpenPGP key fingerprint: 8CD5 52C3 8E3C 4140 715F BA06 3F25 A8FE 3BAE 9A68
next reply other threads:[~2009-07-03 15:25 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-03 15:25 Mathieu Desnoyers [this message]
2009-07-03 15:25 ` [patch 2.6.30 1/4] remove rwsem lock from CPUFREQ_GOV_STOP call (second call site) Mathieu Desnoyers
2009-07-03 15:25 ` [patch 2.6.30 2/4] CPUFREQ: fix (utter) cpufreq_add_dev mess Mathieu Desnoyers
[not found] ` <20090703152714.775719309-scC8bbJcJLCw5LPnMra/2Q@public.gmane.org>
2009-07-03 19:24 ` Pallipadi, Venkatesh
[not found] ` <7E82351C108FA840AB1866AC776AEC4669BFF0F5-osO9UTpF0URqS6EAlXoojrfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2009-07-03 19:41 ` Mathieu Desnoyers
2009-07-06 18:02 ` Pallipadi, Venkatesh
2009-07-03 15:25 ` [patch 2.6.30 3/4] cpufreq add gov mutex Mathieu Desnoyers
[not found] ` <20090703152714.953585501-scC8bbJcJLCw5LPnMra/2Q@public.gmane.org>
2009-07-03 19:11 ` Pallipadi, Venkatesh
[not found] ` <7E82351C108FA840AB1866AC776AEC4669BFF0DE-osO9UTpF0URqS6EAlXoojrfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2009-07-03 19:36 ` Mathieu Desnoyers
2009-07-06 18:50 ` Pallipadi, Venkatesh
[not found] ` <1246906203.11545.47.camel-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org>
2009-07-07 22:59 ` Mathieu Desnoyers
2009-07-03 15:25 ` [patch 2.6.30 4/4] cpufreq ondemand and conservative remove dbs_mutex Mathieu Desnoyers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090703152514.903448283@polymtl.ca \
--to=mathieu.desnoyers-scc8bbjcjlcw5lpnmra/2q@public.gmane.org \
--cc=cpufreq-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=davej-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=trenn-l3A5Bk7waGM@public.gmane.org \
--cc=venkatesh.pallipadi-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).