From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bartlomiej Zolnierkiewicz Subject: Re: [Bug #13663] suspend to ram regression (IDE related) Date: Mon, 6 Jul 2009 16:57:59 +0200 Message-ID: <200907061658.00936.bzolnier@gmail.com> References: <200907031508.47891.bzolnier@gmail.com> <1246635096.16890.6.camel@falcon> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Return-path: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:from:to:subject:date :user-agent:cc:references:in-reply-to:mime-version :content-disposition:message-id:content-type :content-transfer-encoding; bh=wTxBWYAVB2Kt+SfcbT6+WJePMbrTgqKkeh6eXLPGB6Y=; b=NdQQXGHrLvjBoA9TOK7CNdIiFIRt/izrrFtEfaPj/fnX/Ma+yFtnaYaSB+PxUAo/4G qy0qB/TLp8hi6yoRPzskTkNQ+CgCnOO07gaLjjZdPDAJlPcuuBnICmjv7iju8Ooq6+EY vR1UTqHNHvGI3Lo0LcpzFZ5vBdOHgiZPBmFI0= In-Reply-To: <1246635096.16890.6.camel@falcon> Content-Disposition: inline Sender: linux-ide-owner@vger.kernel.org List-ID: Content-Type: Text/Plain; charset="us-ascii" To: wuzhangjin@gmail.com Cc: Jeff Chua , Etienne Basset , David Miller , rjw@sisk.pl, linux-kernel@vger.kernel.org, kernel-testers@vger.kernel.org, Ralf Baechle , linux-mips@linux-mips.org, linux-ide@vger.kernel.org On Friday 03 July 2009 17:31:36 Wu Zhangjin wrote: > Hi, > > > OK, I see another gotcha added by recent changes, we need to explicitly > > initialize rq_in_flight variables now. Revised patch below.. > > > > Sorry, STD also not work. if apply this patch, the same problem as not > apply it, it stopped at: > > ... > PM: Crete hibernation image: > PM: Need to copy ... pages > PM: Hibernation image created ... > > I think it's better to revert this commit: > a1317f714af7aed60ddc182d0122477cbe36ee9b ("ide: improve handling of > Power Management requests") I completely agree and I've already requested this a week ago (this commit was not meant for going straight to -rc tree anyway).