From mboxrd@z Thu Jan 1 00:00:00 1970 From: KOSAKI Motohiro Subject: Re: [Bug #14141] order 2 page allocation failures in iwlagn Date: Tue, 6 Oct 2009 10:25:40 +0900 (JST) Message-ID: <20091006102110.5F9D.A69D9226@jp.fujitsu.com> References: <200910052334.23833.elendil@planet.nl> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Sender: owner-linux-mm@kvack.org List-Id: Content-Type: text/plain; charset="us-ascii" To: David Rientjes Cc: kosaki.motohiro@jp.fujitsu.com, Frans Pop , Mel Gorman , "Rafael J. Wysocki" , Linux Kernel Mailing List , Kernel Testers List , Pekka Enberg , Reinette Chatre , Bartlomiej Zolnierkiewicz , Karol Lewandowski , linux-mm@kvack.org > On Mon, 5 Oct 2009, Frans Pop wrote: > > > And the winner is: > > 2ff05b2b4eac2e63d345fc731ea151a060247f53 is first bad commit > > commit 2ff05b2b4eac2e63d345fc731ea151a060247f53 > > Author: David Rientjes > > Date: Tue Jun 16 15:32:56 2009 -0700 > > > > oom: move oom_adj value from task_struct to mm_struct > > > > I'm confident that the bisection is good. The test case was very reliable > > while zooming in on the merge from akpm. > > > > I doubt it for two reasons: (i) this commit was reverted in 0753ba0 since > 2.6.31-rc7 and is no longer in the kernel, and (ii) these are GFP_ATOMIC > allocations which would be unaffected by oom killer scores. I agree. this patch is pretty obvious correct. it was reverted by one unfortunately regression. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org