From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jens Axboe Subject: Re: [PATCH 5/5] ONLY-APPLY-IF-STILL-FAILING Revert 373c0a7e, 8aa7e847: Fix congestion_wait() sync/async vs read/write confusion Date: Thu, 22 Oct 2009 23:49:34 +0200 Message-ID: <20091022214934.GQ10727@kernel.dk> References: <1256221356-26049-1-git-send-email-mel@csn.ul.ie> <1256221356-26049-6-git-send-email-mel@csn.ul.ie> Mime-Version: 1.0 Return-path: Content-Disposition: inline In-Reply-To: <1256221356-26049-6-git-send-email-mel@csn.ul.ie> Sender: owner-linux-mm@kvack.org List-Id: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Mel Gorman Cc: Frans Pop , Jiri Kosina , Sven Geggus , Karol Lewandowski , Tobias Oetiker , "Rafael J. Wysocki" , David Miller , Reinette Chatre , Kalle Valo , David Rientjes , KOSAKI Motohiro , Mohamed Abbas , "John W. Linville" , Pekka Enberg , Bartlomiej Zolnierkiewicz , Greg Kroah-Hartman , Stephan von Krawczynski , Kernel Testers List , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, "linux-mm@kvack.org" On Thu, Oct 22 2009, Mel Gorman wrote: > Testing by Frans Pop indicates that in the 2.6.30..2.6.31 window at > least that the commits 373c0a7e 8aa7e847 dramatically increased the > number of GFP_ATOMIC failures that were occuring within a wireless > driver. It was never isolated which of the changes was the exact problem > and it's possible it has been fixed since. If problems are still > occuring with GFP_ATOMIC in 2.6.31-rc5, then this patch should be > applied to determine if the congestion_wait() callers are still broken. I still think this is a complete red herring. -- Jens Axboe -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org