From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kulikov Vasiliy Subject: Re: [Bug #24392] AGP aperture disabled, worked in 2.6.35 Date: Tue, 21 Dec 2010 11:42:00 +0300 Message-ID: <20101221084200.GA2537@albatros> References: <201012201214.57068.bjorn.helgaas@hp.com> Mime-Version: 1.0 Return-path: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:date:from:to:cc:subject :message-id:references:mime-version:content-type:content-disposition :in-reply-to:user-agent; bh=mPqupYqC15H94VpQlLh/DYBwaCqIivqcvl6/ZWevBTg=; b=O3PI2rnHyE/N6XkV2eA1Q7S7FI26IUCVxUloj/5pMdWa4ebJpYvhbTB3kZ+1N7HIev 2IfWgXRISB+iE4A2Z0CMXe7Bio2FjDHe/F1z49DYNDVopx1LiMOtNWU1k75ARJ8AG9QR 6UP8kW/aiyIPJofpB1N+/OavdO8rtotCGOW80= Content-Disposition: inline In-Reply-To: <201012201214.57068.bjorn.helgaas-VXdhtT5mjnY@public.gmane.org> Sender: kernel-testers-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-ID: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Bjorn Helgaas Cc: "Rafael J. Wysocki" , Linux Kernel Mailing List , Kernel Testers List , Maciej Rutecki , Florian Mickler , Stephen Kitt , bugzilla-daemon-590EEB7GvNiWaY/ihj7yzEB+6BGkLq7r@public.gmane.org Hi, On Mon, Dec 20, 2010 at 12:14 -0700, Bjorn Helgaas wrote: > > Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=24392 > > First-Bad-Commit: http://git.kernel.org/linus/96576a9e1a0cdb8a43d3af5846be0948f52b4460 ... > That's kind of ugly because it's an exception to the normal "call > pci_enable_device() first" rule, and it leads to bogus "conflicts" > like this: I don't understand rationale, but if standard enable-before-use breaks the boot then explicit comment _why_ do it is necessary here. Thanks, -- Vasiliy