From mboxrd@z Thu Jan 1 00:00:00 1970 From: Minchan Kim Subject: Re: [PATCH 5/5] vmscan: Take order into consideration when deciding if kswapd is in trouble Date: Fri, 13 Nov 2009 21:41:33 +0900 Message-ID: <28c262360911130441h24e45cd8l60e5e10aed0d3650@mail.gmail.com> References: <1258054235-3208-1-git-send-email-mel@csn.ul.ie> <1258054235-3208-6-git-send-email-mel@csn.ul.ie> Mime-Version: 1.0 Return-path: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:in-reply-to:references :date:message-id:subject:from:to:cc:content-type; bh=8vInHgPRWNEtf1Xg0Lm/e2fIJJO+nRUrfIOwbqip4YM=; b=Bkf9J+980l6ZN/iF0VJJF29PjfN9G5kIRj/9zES0ucmYzJ25X8oae/1IjkrREg298j 6EpGGs/T4NOLd+qgKob5wLDCS+eu2WOpBcNJ9pU5AyBUHEWvMttRh8RgAF06of+uAez0 9Ndjzz1wEC45pdU/DnXbqdYkmba0jiplHoLjs= In-Reply-To: <1258054235-3208-6-git-send-email-mel-wPRd99KPJ+uzQB+pC5nmwQ@public.gmane.org> Sender: kernel-testers-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-ID: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Mel Gorman Cc: Andrew Morton , Frans Pop , Jiri Kosina , Sven Geggus , Karol Lewandowski , Tobias Oetiker , linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, "linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org\"" , KOSAKI Motohiro , Pekka Enberg , Rik van Riel , Christoph Lameter , Stephan von Krawczynski , "Rafael J. Wysocki" , Kernel Testers List On Fri, Nov 13, 2009 at 4:30 AM, Mel Gorman wrote: > If reclaim fails to make sufficient progress, the priority is raised. > Once the priority is higher, kswapd starts waiting on congestion. > However, on systems with large numbers of high-order atomics due to > crappy network cards, it's important that kswapd keep working in > parallel to save their sorry ass. > > This patch takes into account the order kswapd is reclaiming at before > waiting on congestion. The higher the order, the longer it is before > kswapd considers itself to be in trouble. The impact is that kswapd > works harder in parallel rather than depending on direct reclaimers or > atomic allocations to fail. > > Signed-off-by: Mel Gorman It's make sense to me. It can help high order atomic allocation which is a big problem of allocator. :) Thanks Mel. Reviewed-by: Minchan Kim -- Kind regards, Minchan Kim