From: KOSAKI Motohiro <kosaki.motohiro-+CUm20s59erQFUHtdCDX3A@public.gmane.org>
To: Mel Gorman <mel-wPRd99KPJ+uzQB+pC5nmwQ@public.gmane.org>
Cc: Andrew Morton
<akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org>,
Frans Pop <elendil-EIBgga6/0yRmR6Xm/wNWPw@public.gmane.org>,
Jiri Kosina <jkosina-AlSwsSmVLrQ@public.gmane.org>,
Sven Geggus
<lists-+AJD3D7QEjjt/htJsj1pd9AswbaBtrod@public.gmane.org>,
Karol Lewandowski
<karol.k.lewandowski-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
Tobias Oetiker <tobi-7K0TWYW2a3pyDzI6CaY1VQ@public.gmane.org>,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
"linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org"
<linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org>,
Pekka Enberg <penberg-bbCR+/B0CizivPeTLB3BmA@public.gmane.org>,
Rik van Riel <riel-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>,
Christoph Lameter
<cl-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org>,
Stephan von Krawczynski
<skraw-DcQCyzbjH0jQT0dZR+AlfA@public.gmane.org>,
"Rafael J. Wysocki" <rjw-KKrjLPT3xs0@public.gmane.org>,
Kernel Testers List
<kernel-testers-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: [PATCH] vmscan: Stop kswapd waiting on congestion when the min watermark is not being met
Date: Sat, 14 Nov 2009 03:33:16 +0900 [thread overview]
Message-ID: <2f11576a0911131033w4a9e6042k3349f0be290a167e@mail.gmail.com> (raw)
In-Reply-To: <20091113181557.GM29804-wPRd99KPJ+uzQB+pC5nmwQ@public.gmane.org>
> @@ -2092,8 +2102,12 @@ loop_again:
> * OK, kswapd is getting into trouble. Take a nap, then take
> * another pass across the zones.
> */
> - if (total_scanned && priority < DEF_PRIORITY - 2)
> - congestion_wait(BLK_RW_ASYNC, HZ/10);
> + if (total_scanned && (priority < DEF_PRIORITY - 2)) {
> + if (!has_under_min_watermark_zone)
if I am correct, we must to remove "!".
> + count_vm_event(KSWAPD_NO_CONGESTION_WAIT);
> + else
> + congestion_wait(BLK_RW_ASYNC, HZ/10);
> + }
next prev parent reply other threads:[~2009-11-13 18:33 UTC|newest]
Thread overview: 57+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-12 19:30 [PATCH 0/5] Reduce GFP_ATOMIC allocation failures, candidate fix V3 Mel Gorman
2009-11-12 19:30 ` [PATCH 1/5] page allocator: Always wake kswapd when restarting an allocation attempt after direct reclaim failed Mel Gorman
2009-11-13 5:23 ` KOSAKI Motohiro
2009-11-13 13:55 ` Mel Gorman
2009-11-12 19:30 ` [PATCH 2/5] page allocator: Do not allow interrupts to use ALLOC_HARDER Mel Gorman
[not found] ` <1258054235-3208-3-git-send-email-mel-wPRd99KPJ+uzQB+pC5nmwQ@public.gmane.org>
2009-11-13 5:24 ` KOSAKI Motohiro
2009-11-13 13:56 ` Mel Gorman
2009-11-12 19:30 ` [PATCH 3/5] page allocator: Wait on both sync and async congestion after direct reclaim Mel Gorman
[not found] ` <1258054235-3208-4-git-send-email-mel-wPRd99KPJ+uzQB+pC5nmwQ@public.gmane.org>
2009-11-13 11:20 ` KOSAKI Motohiro
[not found] ` <20091113142526.33B3.A69D9226-+CUm20s59erQFUHtdCDX3A@public.gmane.org>
2009-11-13 11:55 ` Jens Axboe
[not found] ` <20091113115558.GY8742-tSWWG44O7X1aa/9Udqfwiw@public.gmane.org>
2009-11-13 12:28 ` Mel Gorman
[not found] ` <20091113122821.GC29804-wPRd99KPJ+uzQB+pC5nmwQ@public.gmane.org>
2009-11-13 13:32 ` Jens Axboe
[not found] ` <20091113133211.GA8742-tSWWG44O7X1aa/9Udqfwiw@public.gmane.org>
2009-11-13 13:41 ` Pekka Enberg
2009-11-13 15:22 ` Chris Mason
2009-11-13 14:16 ` Mel Gorman
2009-11-20 14:56 ` Mel Gorman
2009-11-12 19:30 ` [PATCH 4/5] vmscan: Have kswapd sleep for a short interval and double check it should be asleep Mel Gorman
2009-11-13 10:43 ` KOSAKI Motohiro
[not found] ` <20091113142558.33B6.A69D9226-+CUm20s59erQFUHtdCDX3A@public.gmane.org>
2009-11-13 14:13 ` Mel Gorman
2009-11-13 18:00 ` KOSAKI Motohiro
[not found] ` <20091114023901.3DA8.A69D9226-+CUm20s59erQFUHtdCDX3A@public.gmane.org>
2009-11-13 18:17 ` Mel Gorman
[not found] ` <20091113181740.GN29804-wPRd99KPJ+uzQB+pC5nmwQ@public.gmane.org>
2009-11-14 9:34 ` KOSAKI Motohiro
[not found] ` <2f11576a0911140134u21eafa83t9642bb25ccd953de-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2009-11-14 15:46 ` Mel Gorman
[not found] ` <20091114154636.GR29804-wPRd99KPJ+uzQB+pC5nmwQ@public.gmane.org>
2009-11-17 11:03 ` KOSAKI Motohiro
[not found] ` <20091117141638.3DCB.A69D9226-+CUm20s59erQFUHtdCDX3A@public.gmane.org>
2009-11-17 11:44 ` Mel Gorman
2009-11-17 12:18 ` KOSAKI Motohiro
2009-11-17 12:25 ` Mel Gorman
[not found] ` <20091117122555.GZ29804-wPRd99KPJ+uzQB+pC5nmwQ@public.gmane.org>
2009-11-18 5:20 ` KOSAKI Motohiro
2009-11-17 10:34 ` [PATCH] vmscan: Have kswapd sleep for a short interval and double check it should be asleep fix 1 Mel Gorman
2009-11-18 5:27 ` KOSAKI Motohiro
2009-11-12 19:30 ` [PATCH 5/5] vmscan: Take order into consideration when deciding if kswapd is in trouble Mel Gorman
2009-11-13 9:54 ` KOSAKI Motohiro
[not found] ` <20091113142608.33B9.A69D9226-+CUm20s59erQFUHtdCDX3A@public.gmane.org>
2009-11-13 13:54 ` Mel Gorman
[not found] ` <20091113135443.GF29804-wPRd99KPJ+uzQB+pC5nmwQ@public.gmane.org>
2009-11-13 14:48 ` Minchan Kim
2009-11-13 18:00 ` KOSAKI Motohiro
[not found] ` <20091114023138.3DA5.A69D9226-+CUm20s59erQFUHtdCDX3A@public.gmane.org>
2009-11-13 18:15 ` [PATCH] vmscan: Stop kswapd waiting on congestion when the min watermark is not being met Mel Gorman
2009-11-13 18:26 ` Frans Pop
[not found] ` <20091113181557.GM29804-wPRd99KPJ+uzQB+pC5nmwQ@public.gmane.org>
2009-11-13 18:33 ` KOSAKI Motohiro [this message]
[not found] ` <2f11576a0911131033w4a9e6042k3349f0be290a167e-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2009-11-13 20:03 ` [PATCH] vmscan: Stop kswapd waiting on congestion when the min watermark is not being met V2 Mel Gorman
[not found] ` <20091113200357.GO29804-wPRd99KPJ+uzQB+pC5nmwQ@public.gmane.org>
2009-11-26 14:45 ` Tobias Oetiker
[not found] ` <alpine.DEB.2.00.0911261542500.21450-EjsAmf5DE5zIvOfxy3zmAzgUDZmNtoG9@public.gmane.org>
2009-11-29 7:42 ` still getting allocation failures (was Re: [PATCH] vmscan: Stop kswapd waiting on congestion when the min watermark is not being met V2) Tobi Oetiker
2009-12-02 11:32 ` Mel Gorman
2009-12-02 21:30 ` Tobias Oetiker
[not found] ` <alpine.DEB.2.00.0912022210220.30023-EjsAmf5DE5zIvOfxy3zmAzgUDZmNtoG9@public.gmane.org>
2009-12-03 20:26 ` Corrado Zoccolo
[not found] ` <4e5e476b0912031226i5b0e6cf9hdfd5519182ccdefa-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2009-12-14 5:59 ` Tobias Oetiker
[not found] ` <alpine.DEB.2.00.0912140646550.12657-EjsAmf5DE5zIvOfxy3zmAzgUDZmNtoG9@public.gmane.org>
2009-12-14 8:49 ` Corrado Zoccolo
2009-11-13 18:36 ` [PATCH] vmscan: Stop kswapd waiting on congestion when the min watermark is not being met Rik van Riel
2009-11-13 14:38 ` [PATCH 5/5] vmscan: Take order into consideration when deciding if kswapd is in trouble Minchan Kim
[not found] ` <1258054235-3208-6-git-send-email-mel-wPRd99KPJ+uzQB+pC5nmwQ@public.gmane.org>
2009-11-13 12:41 ` Minchan Kim
[not found] ` <1258054235-3208-1-git-send-email-mel-wPRd99KPJ+uzQB+pC5nmwQ@public.gmane.org>
2009-11-13 9:04 ` [PATCH 0/5] Reduce GFP_ATOMIC allocation failures, candidate fix V3 Frans Pop
[not found] ` <200911131004.25293.elendil-EIBgga6/0yRmR6Xm/wNWPw@public.gmane.org>
2009-11-16 17:57 ` Mel Gorman
2009-11-13 12:47 ` Tobias Oetiker
[not found] ` <alpine.DEB.2.00.0911131346560.22447-ZxOFkyelvri73kmZFr1Urg@public.gmane.org>
2009-11-13 13:37 ` Mel Gorman
2009-11-15 12:07 ` Karol Lewandowski
[not found] ` <20091115120721.GA7557-nLtalAL5mPp2RxbNQum0x1nzlInOXLuq@public.gmane.org>
2009-11-16 9:52 ` Mel Gorman
2009-11-16 12:08 ` Karol Lewandowski
[not found] ` <20091116120845.GA10115-nLtalAL5mPp2RxbNQum0x1nzlInOXLuq@public.gmane.org>
2009-11-16 14:32 ` Karol Lewandowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2f11576a0911131033w4a9e6042k3349f0be290a167e@mail.gmail.com \
--to=kosaki.motohiro-+cum20s59erqfuhtdcdx3a@public.gmane.org \
--cc=akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org \
--cc=cl-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org \
--cc=elendil-EIBgga6/0yRmR6Xm/wNWPw@public.gmane.org \
--cc=jkosina-AlSwsSmVLrQ@public.gmane.org \
--cc=karol.k.lewandowski-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=kernel-testers-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org \
--cc=lists-+AJD3D7QEjjt/htJsj1pd9AswbaBtrod@public.gmane.org \
--cc=mel-wPRd99KPJ+uzQB+pC5nmwQ@public.gmane.org \
--cc=penberg-bbCR+/B0CizivPeTLB3BmA@public.gmane.org \
--cc=riel-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=rjw-KKrjLPT3xs0@public.gmane.org \
--cc=skraw-DcQCyzbjH0jQT0dZR+AlfA@public.gmane.org \
--cc=tobi-7K0TWYW2a3pyDzI6CaY1VQ@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).