kernel-testers.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Hidehiro Kawai <hidehiro.kawai.ez@hitachi.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: linux-kernel@vger.kernel.org, kernel-testers@vger.kernel.org,
	linux-mm@kvack.org, sugita <yumiko.sugita.yf@hitachi.com>,
	Satoshi OSHIMA <satoshi.oshima.fk@hitachi.com>,
	rusty@rustcorp.com.au
Subject: [BUG][PATCH -mm] avoid BUG() in __stop_machine_run()
Date: Thu, 19 Jun 2008 15:59:50 +0900	[thread overview]
Message-ID: <485A03E6.2090509@hitachi.com> (raw)
In-Reply-To: <20080611225945.4da7bb7f.akpm@linux-foundation.org>

When a process loads a kernel module, __stop_machine_run() is called, and
it calls sched_setscheduler() to give newly created kernel threads highest
priority.  However, the process can have no CAP_SYS_NICE which required
for sched_setscheduler() to increase the priority.  For example, SystemTap
loads its module with only CAP_SYS_MODULE.  In this case,
sched_setscheduler() returns -EPERM, then BUG() is called.

Failure of sched_setscheduler() wouldn't be a real problem, so this
patch just ignores it.
Or, should we give the CAP_SYS_NICE capability temporarily?

Signed-off-by: Hidehiro Kawai <hidehiro.kawai.ez@hitachi.com>
---
 kernel/stop_machine.c |    3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

Index: linux-2.6.26-rc5-mm3/kernel/stop_machine.c
===================================================================
--- linux-2.6.26-rc5-mm3.orig/kernel/stop_machine.c
+++ linux-2.6.26-rc5-mm3/kernel/stop_machine.c
@@ -143,8 +143,7 @@ int __stop_machine_run(int (*fn)(void *)
 		kthread_bind(threads[i], i);
 
 		/* Make it highest prio. */
-		if (sched_setscheduler(threads[i], SCHED_FIFO, &param) != 0)
-			BUG();
+		sched_setscheduler(threads[i], SCHED_FIFO, &param);
 	}
 
 	/* We've created all the threads.  Wake them all: hold this CPU so one


  parent reply	other threads:[~2008-06-19  6:59 UTC|newest]

Thread overview: 100+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-06-12  5:59 2.6.26-rc5-mm3 Andrew Morton
     [not found] ` <20080611225945.4da7bb7f.akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org>
2008-06-12  7:58   ` 2.6.26-rc5-mm3: kernel BUG at mm/vmscan.c:510 Alexey Dobriyan
     [not found]     ` <20080612075858.GA4874-QDJVlCTZ4KWTKS93B3g+7KFoa47nwP16@public.gmane.org>
2008-06-12  8:22       ` Andrew Morton
     [not found]         ` <20080612012205.95eb10e9.akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org>
2008-06-12  8:23           ` Alexey Dobriyan
2008-06-12  8:44   ` [BUG] 2.6.26-rc5-mm3 kernel BUG at mm/filemap.c:575! Kamalesh Babulal
     [not found]     ` <4850E1E5.90806-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>
2008-06-12  8:57       ` Andrew Morton
     [not found]         ` <20080612015746.172c4b56.akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org>
2008-06-12 11:20           ` KAMEZAWA Hiroyuki
     [not found]             ` <20080612202003.db871cac.kamezawa.hiroyu-+CUm20s59erQFUHtdCDX3A@public.gmane.org>
2008-06-13  1:44               ` [PATCH] fix double unlock_page() in " KAMEZAWA Hiroyuki
     [not found]                 ` <20080613104444.63bd242f.kamezawa.hiroyu-+CUm20s59erQFUHtdCDX3A@public.gmane.org>
2008-06-13  2:13                   ` Andrew Morton
     [not found]                     ` <20080612191311.1331f337.akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org>
2008-06-13 15:30                       ` Lee Schermerhorn
2008-06-15  3:59                         ` Kamalesh Babulal
2008-06-16 14:49                         ` Lee Schermerhorn
2008-06-17  2:32                         ` KAMEZAWA Hiroyuki
     [not found]                           ` <20080617113235.cc493c03.kamezawa.hiroyu-+CUm20s59erQFUHtdCDX3A@public.gmane.org>
2008-06-17 15:26                             ` Lee Schermerhorn
2008-06-13  4:34                   ` Valdis.Kletnieks-PjAqaU27lzQ
2008-06-14 13:32                   ` Kamalesh Babulal
2008-06-12 11:38           ` [BUG] " Nick Piggin
2008-06-13  0:25             ` KAMEZAWA Hiroyuki
2008-06-13  4:18       ` Valdis.Kletnieks-PjAqaU27lzQ
     [not found]         ` <4041.1213330723-+bZmOdGhbsPr6rcHtW+onFJE71vCis6O@public.gmane.org>
2008-06-13  7:16           ` Andrew Morton
2008-06-12 23:32   ` 2.6.26-rc5-mm3 Byron Bradley
2008-06-12 23:55     ` 2.6.26-rc5-mm3 Daniel Walker
2008-06-13  0:04       ` 2.6.26-rc5-mm3 Byron Bradley
2008-06-18 17:55     ` 2.6.26-rc5-mm3 Daniel Walker
     [not found]       ` <1213811751.11203.73.camel-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org>
2008-06-19  9:13         ` 2.6.26-rc5-mm3 Ingo Molnar
     [not found]           ` <20080619091337.GA15228-X9Un+BFzKDI@public.gmane.org>
2008-06-19 14:39             ` 2.6.26-rc5-mm3 Daniel Walker
2008-06-17  7:35   ` [PATCH][RFC] fix kernel BUG at mm/migrate.c:719! in 2.6.26-rc5-mm3 Daisuke Nishimura
     [not found]     ` <20080617163501.7cf411ee.nishimura-YQH0OdQVrdy45+QrQBaojngSJqDPrsil@public.gmane.org>
2008-06-17  7:47       ` [Bad page] trying to free locked page? (Re: [PATCH][RFC] fix kernel BUG at mm/migrate.c:719! in 2.6.26-rc5-mm3) Daisuke Nishimura
     [not found]         ` <20080617164709.de4db070.nishimura-YQH0OdQVrdy45+QrQBaojngSJqDPrsil@public.gmane.org>
2008-06-17  9:03           ` KAMEZAWA Hiroyuki
     [not found]             ` <20080617180314.2d1b0efa.kamezawa.hiroyu-+CUm20s59erQFUHtdCDX3A@public.gmane.org>
2008-06-17  9:14               ` KOSAKI Motohiro
2008-06-17  9:15             ` Daisuke Nishimura
     [not found]               ` <20080617181527.5bcbbccc.nishimura-YQH0OdQVrdy45+QrQBaojngSJqDPrsil@public.gmane.org>
2008-06-17 18:29                 ` Lee Schermerhorn
2008-06-17 20:00                   ` [PATCH] unevictable mlocked pages: initialize mm member of munlock mm_walk structure Lee Schermerhorn
2008-06-18  3:33                     ` KOSAKI Motohiro
2008-06-18  2:40                   ` [Bad page] trying to free locked page? (Re: [PATCH][RFC] fix kernel BUG at mm/migrate.c:719! in 2.6.26-rc5-mm3) Daisuke Nishimura
2008-06-17 15:34           ` KOSAKI Motohiro
     [not found]             ` <20080618003334.DE2A.KOSAKI.MOTOHIRO-+CUm20s59erQFUHtdCDX3A@public.gmane.org>
2008-06-18  2:32               ` Daisuke Nishimura
     [not found]                 ` <20080618113235.c89ec08d.nishimura-YQH0OdQVrdy45+QrQBaojngSJqDPrsil@public.gmane.org>
2008-06-18 10:20                   ` KOSAKI Motohiro
2008-06-18  9:40           ` [Experimental][PATCH] putback_lru_page rework KAMEZAWA Hiroyuki
     [not found]             ` <20080618184000.a855dfe0.kamezawa.hiroyu-+CUm20s59erQFUHtdCDX3A@public.gmane.org>
2008-06-18 11:36               ` KOSAKI Motohiro
     [not found]                 ` <20080618195009.37BF.KOSAKI.MOTOHIRO-+CUm20s59erQFUHtdCDX3A@public.gmane.org>
2008-06-18 11:55                   ` KAMEZAWA Hiroyuki
     [not found]                     ` <20080618205540.11a1644b.kamezawa.hiroyu-+CUm20s59erQFUHtdCDX3A@public.gmane.org>
2008-06-19  8:00                       ` Daisuke Nishimura
     [not found]                         ` <20080619170059.60b42e73.nishimura-YQH0OdQVrdy45+QrQBaojngSJqDPrsil@public.gmane.org>
2008-06-19  8:24                           ` KAMEZAWA Hiroyuki
2008-06-18 18:21               ` Lee Schermerhorn
2008-06-19  0:22                 ` KAMEZAWA Hiroyuki
     [not found]                   ` <20080619092242.79648592.kamezawa.hiroyu-+CUm20s59erQFUHtdCDX3A@public.gmane.org>
2008-06-19 14:45                     ` Lee Schermerhorn
2008-06-19 15:32                       ` kamezawa.hiroyu-+CUm20s59erQFUHtdCDX3A
     [not found]                         ` <24280609.1213889550357.kamezawa.hiroyu-+CUm20s59erQFUHtdCDX3A@public.gmane.org>
2008-06-20 16:24                           ` Lee Schermerhorn
2008-06-20  0:47                       ` KAMEZAWA Hiroyuki
2008-06-20  1:13                       ` KAMEZAWA Hiroyuki
     [not found]                         ` <20080620101352.e1200b8e.kamezawa.hiroyu-+CUm20s59erQFUHtdCDX3A@public.gmane.org>
2008-06-20 17:10                           ` Lee Schermerhorn
2008-06-20 20:41                             ` Lee Schermerhorn
2008-06-21  8:56                               ` KOSAKI Motohiro
     [not found]                                 ` <20080621175458.E82A.KOSAKI.MOTOHIRO-+CUm20s59erQFUHtdCDX3A@public.gmane.org>
2008-06-23  0:30                                   ` KAMEZAWA Hiroyuki
2008-06-21  8:41                             ` KOSAKI Motohiro
2008-06-21  8:39                           ` KOSAKI Motohiro
2008-06-18 14:50             ` Daisuke Nishimura
2008-06-17 15:33       ` [PATCH][RFC] fix kernel BUG at mm/migrate.c:719! in 2.6.26-rc5-mm3 KOSAKI Motohiro
     [not found]         ` <20080618003129.DE27.KOSAKI.MOTOHIRO-+CUm20s59erQFUHtdCDX3A@public.gmane.org>
2008-06-18  1:54           ` Daisuke Nishimura
     [not found]             ` <20080618105400.b9f1b664.nishimura-YQH0OdQVrdy45+QrQBaojngSJqDPrsil@public.gmane.org>
2008-06-18  4:41               ` Daisuke Nishimura
     [not found]                 ` <20080618134128.828156bc.nishimura-YQH0OdQVrdy45+QrQBaojngSJqDPrsil@public.gmane.org>
2008-06-18  4:59                   ` KAMEZAWA Hiroyuki
2008-06-18  7:54                   ` [PATCH][-mm] remove redundant page->mapping check KOSAKI Motohiro
2008-06-17 17:46       ` [PATCH][RFC] fix kernel BUG at mm/migrate.c:719! in 2.6.26-rc5-mm3 Lee Schermerhorn
2008-06-17 18:33         ` Hugh Dickins
     [not found]           ` <Pine.LNX.4.64.0806171925200.21436-popGQ1T0qN76K7/ahGyk6A@public.gmane.org>
2008-06-17 19:28             ` Lee Schermerhorn
2008-06-18  5:19               ` Nick Piggin
2008-06-18  2:59         ` Daisuke Nishimura
2008-06-18  1:13       ` KAMEZAWA Hiroyuki
     [not found]         ` <20080618101349.db4d5205.kamezawa.hiroyu-+CUm20s59erQFUHtdCDX3A@public.gmane.org>
2008-06-18  1:26           ` Daisuke Nishimura
2008-06-18  1:54           ` [PATCH] migration_entry_wait fix KAMEZAWA Hiroyuki
     [not found]             ` <20080618105435.de10d6bc.kamezawa.hiroyu-+CUm20s59erQFUHtdCDX3A@public.gmane.org>
2008-06-18  5:26               ` KOSAKI Motohiro
2008-06-18  5:35               ` Nick Piggin
     [not found]                 ` <200806181535.58036.nickpiggin-/E1597aS9LT0CCvOHzKKcA@public.gmane.org>
2008-06-18  6:04                   ` KAMEZAWA Hiroyuki
     [not found]                     ` <20080618150436.dca5eb75.kamezawa.hiroyu-+CUm20s59erQFUHtdCDX3A@public.gmane.org>
2008-06-18  6:42                       ` Nick Piggin
     [not found]                         ` <200806181642.38379.nickpiggin-/E1597aS9LT0CCvOHzKKcA@public.gmane.org>
2008-06-18  6:52                           ` KAMEZAWA Hiroyuki
     [not found]                             ` <20080618155233.7dd79312.kamezawa.hiroyu-+CUm20s59erQFUHtdCDX3A@public.gmane.org>
2008-06-18  7:29                               ` [PATCH -mm][BUGFIX] migration_entry_wait fix. v2 KAMEZAWA Hiroyuki
     [not found]                                 ` <20080618162944.2f8fd265.kamezawa.hiroyu-+CUm20s59erQFUHtdCDX3A@public.gmane.org>
2008-06-18  7:26                                   ` KOSAKI Motohiro
2008-06-18  7:40                                   ` Nick Piggin
2008-06-19 16:27   ` 2.6.26-rc5-mm3: BUG large value for HugePages_Rsvd Jon Tollefson
     [not found]     ` <485A8903.9030808-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>
2008-06-19 17:16       ` Andy Whitcroft
     [not found]         ` <20080619171644.GC13275-26w3C0LaAnFg9hUCZPvPmw@public.gmane.org>
2008-06-20  3:18           ` Jon Tollefson
2008-06-20 19:17       ` [RFC] hugetlb reservations -- MAP_PRIVATE fixes for split vmas Andy Whitcroft
2008-06-20 19:17         ` [PATCH 1/2] hugetlb reservations: move region tracking earlier Andy Whitcroft
     [not found]         ` <1213989474-5586-1-git-send-email-apw-26w3C0LaAnFg9hUCZPvPmw@public.gmane.org>
2008-06-20 19:17           ` [PATCH 2/2] hugetlb reservations: fix hugetlb MAP_PRIVATE reservations across vma splits Andy Whitcroft
     [not found]             ` <1213989474-5586-3-git-send-email-apw-26w3C0LaAnFg9hUCZPvPmw@public.gmane.org>
2008-06-23  7:33               ` Mel Gorman
2008-06-23  8:00               ` Mel Gorman
     [not found]                 ` <20080623080048.GJ21597-wPRd99KPJ+uzQB+pC5nmwQ@public.gmane.org>
2008-06-23  9:53                   ` Andy Whitcroft
2008-06-23 16:04           ` [RFC] hugetlb reservations -- MAP_PRIVATE fixes for split vmas Jon Tollefson
2008-06-23 17:35       ` [RFC] hugetlb reservations -- MAP_PRIVATE fixes for split vmas V2 Andy Whitcroft
     [not found]         ` <1214242533-12104-1-git-send-email-apw-26w3C0LaAnFg9hUCZPvPmw@public.gmane.org>
2008-06-23 17:35           ` [PATCH 1/2] hugetlb reservations: move region tracking earlier Andy Whitcroft
     [not found]             ` <1214242533-12104-2-git-send-email-apw-26w3C0LaAnFg9hUCZPvPmw@public.gmane.org>
2008-06-23 23:05               ` Mel Gorman
2008-06-23 17:35           ` [PATCH 2/2] hugetlb reservations: fix hugetlb MAP_PRIVATE reservations across vma splits V2 Andy Whitcroft
     [not found]             ` <1214242533-12104-3-git-send-email-apw-26w3C0LaAnFg9hUCZPvPmw@public.gmane.org>
2008-06-23 23:08               ` Mel Gorman
2008-06-25 21:22         ` [RFC] hugetlb reservations -- MAP_PRIVATE fixes for split vmas V2 Jon Tollefson
2008-06-19  6:59 ` Hidehiro Kawai [this message]
     [not found]   ` <485A03E6.2090509-FCd8Q96Dh0JBDgjK7y7TUQ@public.gmane.org>
2008-06-19 10:12     ` [BUG][PATCH -mm] avoid BUG() in __stop_machine_run() Rusty Russell
     [not found]       ` <200806192012.44459.rusty-8n+1lVoiYb80n/F98K4Iww@public.gmane.org>
2008-06-19 15:51         ` Jeremy Fitzhardinge
     [not found]           ` <485A806A.2090602-TSDbQ3PG+2Y@public.gmane.org>
2008-06-20 13:21             ` Ingo Molnar
     [not found]               ` <20080620132110.GB19740-X9Un+BFzKDI@public.gmane.org>
2008-06-23  3:55                 ` Rusty Russell
     [not found]                   ` <200806231355.39329.rusty-8n+1lVoiYb80n/F98K4Iww@public.gmane.org>
2008-06-23 21:01                     ` Ingo Molnar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=485A03E6.2090509@hitachi.com \
    --to=hidehiro.kawai.ez@hitachi.com \
    --cc=akpm@linux-foundation.org \
    --cc=kernel-testers@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=rusty@rustcorp.com.au \
    --cc=satoshi.oshima.fk@hitachi.com \
    --cc=yumiko.sugita.yf@hitachi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).