From mboxrd@z Thu Jan 1 00:00:00 1970 From: "H. Peter Anvin" Subject: Re: wrong final bzImage build (regading #14270) Date: Fri, 09 Oct 2009 14:29:20 -0700 Message-ID: <4ACFAB30.7020104@zytor.com> References: <4ACF460E.7000901@msgid.tls.msk.ru> <20091009145825.GE5311@lenovo> <4ACF9184.9040104@msgid.tls.msk.ru> <200910092202.51208.a.miskiewicz@gmail.com> <4ACFA36F.6000105@zytor.com> <4ACFAAB7.4000308@msgid.tls.msk.ru> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <4ACFAAB7.4000308@msgid.tls.msk.ru> Sender: linux-kernel-owner@vger.kernel.org List-ID: Content-Type: text/plain; charset="us-ascii" To: Michael Tokarev Cc: Arkadiusz Miskiewicz , linux-kernel@vger.kernel.org, Cyrill Gorcunov , "Rafael J. Wysocki" , Kernel Testers List , Sam Ravnborg On 10/09/2009 02:27 PM, Michael Tokarev wrote: > H. Peter Anvin wrote: >> On 10/09/2009 01:02 PM, Arkadiusz Miskiewicz wrote: >>> I had exactly this problem few weeks ago with pdksh as /bin/sh (and >>> bugreported to author of that change). As I workaround I used /bin/echo but >>> using printf is more sane/portable. >>> >> >> Yes, using printf is the right thing to do. >> >> A patch would be appreciated. > > Come on, it's just a one-word change (s/echo/printf/ in > scripts/Makefile.lib). > But it should go to Sam's tree first I guess, which already > has s|echo|/bin/echo| so it'll conflict. > It's easier to change it in whatever tree it will be changed > without complete patches. So send a patch against Sam's tree. -hpa