Re: [Bug #16161] [2.6.35-rc1 regression] sysfs: cannot create duplicate filename ... XVR-600 related?

Jesse Barnes
2010-06-18T20:43:16Z

On Fri, 18 Jun 2010 16:40:44 -0400
Brian Bloniarz <bmb-FfUH/8kkONhWk0Htik3J/w@public.gmane.org> wrote:

> On 06/18/2010 04:26 PM, David Miller wrote:
> > From: Jesse Barnes <jbarnes-Y1mF5jBUw70BENJcbMCuUQ@public.gmane.org>
> > Date: Fri, 18 Jun 2010 13:10:49 -0700
> >
> >> I reverted the symlink patch that was causing the trouble. The root
> >> cause is elsewhere though; it seems some firmwares report duplicate PCI
> >> slot numbers...
> >
> > Instead of postulating, you can confirm or deny such a theory
> > by taking a look at the repository of sparc openfirmware tree
> > dumps maintained at:
> >
> > master.kernel.org:/pub/scm/linux/kernel/git/davem/prtconfs.git
>
> (Adding Alex Chiang to the cc list)
>
> I was actually under the impression that it was just an
> issue with the reverted patch, not an actual problem with
> hardware.

Yeah, I think you're right. I reverted it at Alex's request and
assumed it was a firmware or configuration problem. Looking at the
thread again I see that was a bad assumption.

> In the patch, 2 individual code paths were trying to
> create the same symlinks:
> pci-sysfs.c:pci_create_slot_links(struct pci_dev *dev)
> and
> slot.c:create_sysfs_files(struct pci_slot *slot).
> I think some archs managed to call those both during
> initialization, and some not.

Well that would explain it too. I'm happy to take a fixed up patch if
there's demand.

Thanks,
--
Jesse Barnes, Intel Open Source Technology Center