Re: [Bug #14670] i915: playing video via XVideo extension makes the screen flicker

Jesse Barnes
2010-01-11T16:55:27Z

On Mon, 11 Jan 2010 17:53:04 +0100
Thomas Meyer <thomas@m3y3r.de> wrote:

> Am Sonntag, den 10.01.2010, 23:56 +0100 schrieb Rafael J. Wysocki:
> > This message has been generated automatically as a part of a report
> > of regressions introduced between 2.6.31 and 2.6.32.
> >
> > The following bug entry is on the current list of known regressions
> > introduced between 2.6.31 and 2.6.32. Please verify if it still
> > should be listed and let me know (either way).
> >
>
> Yes, still should be listed.
>
> Problem still exists in 2.6.32.3 and 2.6.33-rc3-00097-g2c1f189, that
> contains
> this commit:
> http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=cda9d05c499093c67b4a376a15009923acc2127a
>
> The above commit removes the render reclock support, that ought to
> fix a common kind of problem encountered on i915 hardware, but not on
> my machine.
>
> Still need to boot with "nomodeset" to have a workable system.

Does this patch prevent the flicker?

--
Jesse Barnes, Intel Open Source Technology Center

diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c
index 9187a17..0ab1bef 100644
--- a/drivers/gpu/drm/i915/intel_display.c
+++ b/drivers/gpu/drm/i915/intel_display.c
@@ -3806,7 +3806,7 @@ static void intel_increase_pllclock(struct drm_crtc *crtc, bool schedule)
if (IS_IRONLAKE(dev))
return;

- if (!dev_priv->lvds_downclock_avail)
+ if (!dev_priv->lvds_downclock_avail || 1)
return;

if (!HAS_PIPE_CXSR(dev) && (dpll & DISPLAY_RATE_SELECT_FPA1)) {
@@ -3845,7 +3845,7 @@ static void intel_decrease_pllclock(struct drm_crtc *crtc)
if (IS_IRONLAKE(dev))
return;

- if (!dev_priv->lvds_downclock_avail)
+ if (!dev_priv->lvds_downclock_avail || 1)
return;

/*