Re: [Bug #14670] i915: playing video via XVideo extension makes the screen flicker

Thomas Meyer
2010-01-11T18:05:58Z

Am Montag, den 11.01.2010, 08:55 -0800 schrieb Jesse Barnes:
> On Mon, 11 Jan 2010 17:53:04 +0100
> Thomas Meyer <thomas-VsYtu1Qij5c@public.gmane.org> wrote:
>
> > Am Sonntag, den 10.01.2010, 23:56 +0100 schrieb Rafael J. Wysocki:
> > > This message has been generated automatically as a part of a report
> > > of regressions introduced between 2.6.31 and 2.6.32.
> > >
> > > The following bug entry is on the current list of known regressions
> > > introduced between 2.6.31 and 2.6.32. Please verify if it still
> > > should be listed and let me know (either way).
> > >
> >
> > Yes, still should be listed.
> >
> > Problem still exists in 2.6.32.3 and 2.6.33-rc3-00097-g2c1f189, that
> > contains
> > this commit:
> > http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=cda9d05c499093c67b4a376a15009923acc2127a
> >
> > The above commit removes the render reclock support, that ought to
> > fix a common kind of problem encountered on i915 hardware, but not on
> > my machine.
> >
> > Still need to boot with "nomodeset" to have a workable system.
>
> Does this patch prevent the flicker?

No, sorry.

Reverting b42d4c5c6a872815d711e5d51a600f5122c38eee (i.e. the commit I
bisect my problem to) on top of 3c8ad49b015eb115fbd6982f56d530f53cf57f84
(i.e. 2.6.33-rc3-00147-g3c8ad49) make the problem go away.

My changes are:

diff --git a/drivers/gpu/drm/i915/intel_lvds.c b/drivers/gpu/drm/i915/intel_lvds.c
index f4b4aa2..15c6e6b 100644
--- a/drivers/gpu/drm/i915/intel_lvds.c
+++ b/drivers/gpu/drm/i915/intel_lvds.c
@@ -629,6 +629,8 @@ static enum drm_connector_status intel_lvds_detect(struct drm_connector *connect
{
enum drm_connector_status status = connector_status_connected;

+ return status;
+
if (!acpi_lid_open() && !dmi_check_system(bad_lid_status))
status = connector_status_disconnected;