Re: 2.6.29-rc8: Reported regressions from 2.6.28

Linus Torvalds
2009-03-15T18:44:31Z

On Sun, 15 Mar 2009, Johannes Berg wrote:

> On Sun, 2009-03-15 at 11:06 +0800, Jeff Chua wrote:
>
> > The commit below is causing problem with associating with the hidden AP as well.
>
> > 71c11fb57b924c160297ccd9e1761db598d00ac2 is first bad commit
> > commit 71c11fb57b924c160297ccd9e1761db598d00ac2
> > Author: Johannes Berg <johannes-cdvu00un1VgdHxzADdlk8Q@public.gmane.org>
> > Date: Tue Oct 28 18:29:48 2008 +0100
> >
> > b43/legacy: remove SSID code
> >
> > The SSID programmed into the device is used by the ucode only
> > to reply to probe requests, a functionality we disable anyway
> > because it doesn't fit with the mac80211/hostapd programming
> > model. Therefore, it isn't useful to program the SSID into
> > device.
>
> That's not believable, sorry. I know exactly what the microcode uses the
> SSID here for, and it never uses it when we're in station mode.

Jeff - can you test the kernels before-and-after this commit (with _no_
other changes) and descibe the differences?

Johannes - "not believable" is simply not an argument. If Jeff can show a
difference, then your disbelief is totally irrelevant, and clearly shows
that you are basing your beliefs on incorrect assumptions (like some
specific version of firmware that isn't the whole story).

Linus