Re: [Bug #11308] tbench regression on each kernel release from 2.6.22 -> 2.6.28

Ilpo Järvinen
2008-09-18T07:58:45Z

On Thu, 18 Sep 2008, Mike Galbraith wrote:

> On Thu, 2008-09-18 at 09:12 +0200, Mike Galbraith wrote:
>
> > 1e65e841bb5584136ed6047c55cf77532afbbb55 is first bad commit
> > commit 1e65e841bb5584136ed6047c55cf77532afbbb55
> > Author: Mike Galbraith <efault-Mmb7MZpHnFY@public.gmane.org>
> > Date: Wed Sep 17 14:55:50 2008 +0200
> >
> > Revert "Revert "block: export "ro" attribute""
> >
> > This reverts commit 2c8803af5c1bf41200167f29349f7f1396683a51.
>
> BTW, the reason it's revert revert is that I reverse bisected the revert
> tree yesterday, and it emitted the same darn result. I immediately said
> "yeah right, ya screwed up", and created the revert revert tree to make
> sure I couldn't fumble negation.

:-)

gcc compiling something slightly differently would be a nice theory but
it sort of breaks down now as this commit touches only one .c file...
In the past when I did some static inline .h -> .c uninline sizing tests
I noticed that some changes happened also in places which should have been
quite much unrelated. Though all the changes were minor anyway (in the
places I did look), e.g., routed the conditional paths slightly
differently and added one xor clear reg.

--
i.