From mboxrd@z Thu Jan 1 00:00:00 1970 From: Linus Torvalds Subject: Re: 2.6.27-rc4-git1: Reported regressions from 2.6.26 Date: Sun, 24 Aug 2008 11:58:09 -0700 (PDT) Message-ID: References: <19f34abd0808241143t6f5239d7o679135e9e974fe63@mail.gmail.com> Mime-Version: 1.0 Return-path: In-Reply-To: <19f34abd0808241143t6f5239d7o679135e9e974fe63-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> Sender: kernel-testers-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-ID: Content-Type: TEXT/PLAIN; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Vegard Nossum Cc: "Rafael J. Wysocki" , Daniel J Blueman , Thomas Gleixner , Ingo Molnar , Linux Kernel Mailing List , Adrian Bunk , Andrew Morton , Natalie Protasevich , Kernel Testers List On Sun, 24 Aug 2008, Vegard Nossum wrote: > > I haven't really used the hlists before, so my first instinct was to > do what is obvious. I do agree that the hlist versions aren't very nice in this regard. The regular lists are much better at moving lists around. > Other than that, I guess open-coding list ops is also not very good > programming practice? :-) Agreed. It would be better if the people who use hlists most (I think that would be networking) would think about this. > But... feel free to submit your own patch. Oh, what am I saying. Silly boy. Next you'll ask me to _test_ any patches I send out. Anyway, I think your patch is likely fine, I just thought it looked a bit odd to have a loop to move a list from one head pointer to another. But regardless, it would need some testing. Daniel? Linus