From mboxrd@z Thu Jan 1 00:00:00 1970 From: Linus Torvalds Subject: Re: [Bug #14015] pty regressed again, breaking expect and gcc's testsuite Date: Fri, 4 Sep 2009 07:33:17 -1000 (HST) Message-ID: References: <19099.52899.620345.326521@pilspetsen.it.uu.se> <19100.31254.666066.755541@pilspetsen.it.uu.se> <200909012042.59856.rjw@sisk.pl> <87pra89sgp.fsf@devron.myhome.or.jp> <20090904162807.1dba7a32@lxorguk.ukuu.org.uk> Mime-Version: 1.0 Return-path: In-Reply-To: <20090904162807.1dba7a32-qBU/x9rampVanCEyBjwyrvXRex20P6io@public.gmane.org> Sender: kernel-testers-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-ID: Content-Type: TEXT/PLAIN; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Alan Cox Cc: OGAWA Hirofumi , "Rafael J. Wysocki" , Mikael Pettersson , Linux Kernel Mailing List , Kernel Testers List , Alan Cox , Greg KH , Andrew Morton On Fri, 4 Sep 2009, Alan Cox wrote: > > In which case ppp will no longer work properly in some cases (ditto > other protocols) and things like the pppoe gateway wont work as they > don't in 2.6.30 - you need to go back to somewhere between 2.6.28/29 to > undo this, then apply the alternative locking patches to the > ppp/slip/ax25/etc ldiscs It should be fairly trivial to just add the locking to the pty write routines. That said, we need to fix the 2.6.31 regression, and right now that is the big one. If we go back to broken 2.6.30 situation, that's way more acceptable. But I'm still hoping we can fix this. Linus