From mboxrd@z Thu Jan 1 00:00:00 1970 From: Linus Torvalds Subject: Re: [Bug #15124] PCI host bridge windows ignored (works with pci=use_crs) Date: Wed, 27 Jan 2010 12:50:12 -0800 (PST) Message-ID: References: <201001270945.17113.bjorn.helgaas@hp.com> <20100127085337.6ff06f6e@jbarnes-piketon> <201001271345.54454.bjorn.helgaas@hp.com> Mime-Version: 1.0 Return-path: In-Reply-To: <201001271345.54454.bjorn.helgaas-VXdhtT5mjnY@public.gmane.org> Sender: kernel-testers-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-ID: Content-Type: TEXT/PLAIN; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Bjorn Helgaas Cc: Jesse Barnes , Yinghai Lu , Jeff Garrett , "Rafael J. Wysocki" , Linux Kernel Mailing List , Kernel Testers List , Linux PCI , Myron Stowe , Matthew Garrett , Ingo Molnar On Wed, 27 Jan 2010, Bjorn Helgaas wrote: > > Without intel_bus.c, we essentially assume config 1 all the time. > If we keep intel_bus.c and this patch for .33, things should work > for configs 1 and 4. Adding support for config 4 is good. Quite frankly, is there any major downside to just disabling/removing intel_bus.c for 2.6.33? If we're not planning on having it in the long run anyway - or even if we are, but we can't be really happy about the state of it as it would be in 2.6.33, not using it at all seems to be the smaller headache. The machines that it helps are also the machines where you can fix things up with 'use_csr', no? And they are pretty rare, and they didn't use to work without that use_csr in 2.6.32 either, so it's not even a regression. Am I missing something? Linus