From mboxrd@z Thu Jan 1 00:00:00 1970 From: Linus Torvalds Subject: Re: [PATCH] x86/pci: print ioh resources only Date: Thu, 28 Jan 2010 10:54:03 -0800 (PST) Message-ID: References: <201001261348.59508.rjw@sisk.pl> <201001261032.37053.bjorn.helgaas@hp.com> <201001261902.13911.rjw@sisk.pl> <20100126101752.78196900@jbarnes-piketon> <4B5F735B.2040308@kernel.org> <20100127192409.79af96db@jbarnes-piketon> <20100128040226.GB8964@jgarrett.org> <20100128082432.05a97ebc@jbarnes-piketon> <4B61D7C4.1050405@kernel.org> Mime-Version: 1.0 Return-path: In-Reply-To: <4B61D7C4.1050405-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> Sender: kernel-testers-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-ID: Content-Type: TEXT/PLAIN; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Yinghai Lu Cc: Jesse Barnes , Jeff Garrett , "Rafael J. Wysocki" , Bjorn Helgaas , Linux Kernel Mailing List , Kernel Testers List , Linux PCI , Myron Stowe , Matthew Garrett , Ingo Molnar On Thu, 28 Jan 2010, Yinghai Lu wrote: > @@ -43,7 +43,7 @@ static void __devinit pci_root_bus_res(s > { > u16 word; > u32 dword; > - struct pci_root_info *info; > + struct pci_root_info info; That structure is something like a kilobyte in size, please don't put those things on the stack (sixteen "struct resource" entries). Linus