From mboxrd@z Thu Jan 1 00:00:00 1970 From: Linus Torvalds Subject: Re: [Bug #14388] keyboard under X with 2.6.31 Date: Wed, 14 Oct 2009 08:07:36 -0700 (PDT) Message-ID: References: <56acieJJ2fF.A.nEB.Hzl0KB@chimera> <87ljjgfcbu.fsf@spindle.srvr.nix> <4AD3F769.5080405@gmail.com> <4AD437F9.9020708@yahoo.co.uk> <4AD4DE4C.4010402@yahoo.co.uk> <4AD4F548.2030506@microgate.com> <1255478932.19056.24.camel@localhost.localdomain> <4AD51D6B.7010509@microgate.com> <20091014125846.1a3c8d40@lxorguk.ukuu.org.uk> Mime-Version: 1.0 Return-path: In-Reply-To: <20091014125846.1a3c8d40@lxorguk.ukuu.org.uk> Sender: linux-kernel-owner@vger.kernel.org List-ID: Content-Type: TEXT/PLAIN; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Alan Cox Cc: Paul Fulghum , Boyan , "Rafael J. Wysocki" , Linux Kernel Mailing List , Kernel Testers List , Dmitry Torokhov , Ed Tomlinson , "OGAWA Hirofumi \"" On Wed, 14 Oct 2009, Alan Cox wrote: > > Stop a moment. The code wasn't designed to permit two paralle calls of > flush_to_ldisc to the same tty. That was always forbidden when that code > was designed. No, the code was clearly _designed_ for it - that's the whole and only point of the tty->buf.head = NULL; line. But it's certainly true that it just never happened before. At least for the !low_latency case, I'm not so sure about the low_latency=1 case, but I haven't checked either - it would depend on any higher-level serialization. Linus