Re: [Bug #23102] [bisected] i915 regression in post 2.6.36 kernels

Johannes Hirte
2010-12-03T00:20:05Z

On Friday 03 December 2010 00:41:44 Rafael J. Wysocki wrote:
> This message has been generated automatically as a part of a summary report
> of recent regressions.
>
> The following bug entry is on the current list of known regressions
> from 2.6.36. Please verify if it still should be listed and let the tracking team
> know (either way).
>
>
> Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=23102
> Subject : [bisected] i915 regression in post 2.6.36 kernels
> Submitter : Johannes Hirte <johannes.hirte@fem.tu-ilmenau.de>
> Date : 2010-11-10 7:02 (23 days old)
> Message-ID : <201011100802.20332.johannes.hirte@fem.tu-ilmenau.de>
> References : http://marc.info/?l=linux-kernel&m=128937310017057&w=2

Still not fixed. As I mentioned, the revert of
5c12a07e8073295ce8b57a822f811ac34e4f8420 missed some lines. I'm not familiar
with the hardware or the code, so I'm not sure if this patch is right. At least
it solves the bug for me. Chris any objection to re-adding it?

diff --git a/drivers/gpu/drm/i915/i915_gem.c b/drivers/gpu/drm/i915/i915_gem.c
index ef188e3..bace93c 100644
--- a/drivers/gpu/drm/i915/i915_gem.c
+++ b/drivers/gpu/drm/i915/i915_gem.c
@@ -2042,6 +2042,11 @@ i915_gem_flush_ring(struct drm_device *dev,
{
ring->flush(dev, ring, invalidate_domains, flush_domains);
i915_gem_process_flushing_list(dev, flush_domains, ring);
+
+ if (ring->outstanding_lazy_request) {
+ (void)i915_add_request(dev, file_priv, NULL, ring);
+ ring->outstanding_lazy_request = false;
+ }
}

static void